Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1460915
| From | Ian Kent <raven@themaw.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 06/18] autofs - remove ino free in autofs4_dir_symlink() |
| Date | 2016-08-12 04:50 +0200 |
| Message-ID | <s5aHM-4bR-37@gated-at.bofh.it> (permalink) |
| References | <s5aHL-4bR-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The inode allocation failure case in autofs4_dir_symlink() frees
the autofs dentry info of the dentry without setting ->d_fsdata to
NULL.
That could lead to a double free so just get rid of the free and
leave it to ->d_release().
Signed-off-by: Ian Kent <raven@themaw.net>
Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
---
fs/autofs4/root.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index fa84bb8..1b0495a 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -577,8 +577,6 @@ static int autofs4_dir_symlink(struct inode *dir,
inode = autofs4_get_inode(dir->i_sb, S_IFLNK | 0555);
if (!inode) {
kfree(cp);
- if (!dentry->d_fsdata)
- kfree(ino);
return -ENOMEM;
}
inode->i_private = cp;
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/18] autofs: Fix typos in Documentation/filesystems/autofs4.txt Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 04/18] autofs - fix autofs4_fill_super() error exit handling Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 15/18] autofs: Add autofs_dev_ioctl_version() for AUTOFS_DEV_IOCTL_VERSION_CMD Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 13/18] autofs: Fix pr_debug() message Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 18/18] autofs4 - move linux/auto_dev-ioctl.h to uapi/linux Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 05/18] autofs: Add WARN_ON(1) for non dir/link inode case Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 06/18] autofs - remove ino free in autofs4_dir_symlink() Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 11/18] autofs: Fix Documentation regarding devid on ioctl Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 16/18] autofs: Fix print format for ioctl warning message Ian Kent <raven@themaw.net> - 2016-08-12 04:50 +0200 [PATCH 09/18] autofs: Don't fail to free_dev_ioctl(param) Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200 [PATCH 14/18] autofs - fix dev ioctl number range check Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200 [PATCH 12/18] autofs: Update struct autofs_dev_ioctl in Documentation Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200 [PATCH 02/18] autofs: Drop unnecessary extern in autofs_i.h Ian Kent <raven@themaw.net> - 2016-08-12 05:00 +0200
csiph-web