Re: [PATCH] drm/tegra: dpaux: Modify error handling

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod
From	Julia Lawall <julia.lawall@lip6.fr>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/tegra: dpaux: Modify error handling
Date	Sat, 13 Aug 2016 10:10:01 +0200
Message-ID	<s5CaZ-6HB-7@gated-at.bofh.it> (permalink)
References	<s5yqJ-3rD-7@gated-at.bofh.it>
X-Ironport-Av	E=Sophos;i="5.28,514,1464645600"; d="scan'208";a="187562733"
X-X-Sender	jll@hadrien
User-Agent	Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version	1.0
Content-Type	TEXT/PLAIN; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	57
Organization	linux.* mail to news gateway
X-Original-Cc	thierry.reding@gmail.com, airlied@linux.ie, swarren@wwwdotorg.org, gnurou@gmail.com, dri-devel@lists.freedesktop.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 13 Aug 2016 10:00:19 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.10.1608130959510.3344@hadrien>
X-Original-References	<20160813040020.GA11719@amitoj-Inspiron-3542>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1461604

Show key headers only | View raw


On Sat, 13 Aug 2016, Amitoj Kaur Chawla wrote:

> devm_pinctrl_register returns an ERR_PTR in case of error and should
> have an IS_ERR check instead of a null check.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
>   e = devm_pinxtrl_register(...);

Actually, there is a typo here.  devm_pinxtrl_register should be
devm_pinctrl_register.

julia

> if(
> -    !e
> +    IS_ERR(e)
>     )
>     {
>   <+...
>   return
> - ...
> + PTR_ERR(e)
>   ;
>   ...+>
>   }
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
>  drivers/gpu/drm/tegra/dpaux.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
> index 059f409..2fde44c 100644
> --- a/drivers/gpu/drm/tegra/dpaux.c
> +++ b/drivers/gpu/drm/tegra/dpaux.c
> @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
>  	dpaux->desc.owner = THIS_MODULE;
>
>  	dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux);
> -	if (!dpaux->pinctrl) {
> +	if (IS_ERR(dpaux->pinctrl)) {
>  		dev_err(&pdev->dev, "failed to register pincontrol\n");
> -		return -ENODEV;
> +		return PTR_ERR(dpaux->pinctrl);
>  	}
>  #endif
>  	/* enable and clear all interrupts */
> --
> 1.9.1
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/tegra: dpaux: Modify error handling Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-08-13 06:10 +0200
  Re: [PATCH] drm/tegra: dpaux: Modify error handling Julia Lawall <julia.lawall@lip6.fr> - 2016-08-13 10:10 +0200

csiph-web