Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1461591 > unrolled thread
| Started by | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| First post | 2016-08-13 06:10 +0200 |
| Last post | 2016-08-13 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/tegra: dpaux: Modify error handling Amitoj Kaur Chawla <amitoj1606@gmail.com> - 2016-08-13 06:10 +0200
Re: [PATCH] drm/tegra: dpaux: Modify error handling Julia Lawall <julia.lawall@lip6.fr> - 2016-08-13 10:10 +0200
| From | Amitoj Kaur Chawla <amitoj1606@gmail.com> |
|---|---|
| Date | 2016-08-13 06:10 +0200 |
| Subject | [PATCH] drm/tegra: dpaux: Modify error handling |
| Message-ID | <s5yqJ-3rD-7@gated-at.bofh.it> |
devm_pinctrl_register returns an ERR_PTR in case of error and should
have an IS_ERR check instead of a null check.
The Coccinelle semantic patch used to make this change is as follows:
@@
expression e;
@@
e = devm_pinxtrl_register(...);
if(
- !e
+ IS_ERR(e)
)
{
<+...
return
- ...
+ PTR_ERR(e)
;
...+>
}
Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
---
drivers/gpu/drm/tegra/dpaux.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
index 059f409..2fde44c 100644
--- a/drivers/gpu/drm/tegra/dpaux.c
+++ b/drivers/gpu/drm/tegra/dpaux.c
@@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
dpaux->desc.owner = THIS_MODULE;
dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux);
- if (!dpaux->pinctrl) {
+ if (IS_ERR(dpaux->pinctrl)) {
dev_err(&pdev->dev, "failed to register pincontrol\n");
- return -ENODEV;
+ return PTR_ERR(dpaux->pinctrl);
}
#endif
/* enable and clear all interrupts */
--
1.9.1
[toc] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2016-08-13 10:10 +0200 |
| Message-ID | <s5CaZ-6HB-7@gated-at.bofh.it> |
| In reply to | #1461591 |
On Sat, 13 Aug 2016, Amitoj Kaur Chawla wrote:
> devm_pinctrl_register returns an ERR_PTR in case of error and should
> have an IS_ERR check instead of a null check.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @@
> expression e;
> @@
>
> e = devm_pinxtrl_register(...);
Actually, there is a typo here. devm_pinxtrl_register should be
devm_pinctrl_register.
julia
> if(
> - !e
> + IS_ERR(e)
> )
> {
> <+...
> return
> - ...
> + PTR_ERR(e)
> ;
> ...+>
> }
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/gpu/drm/tegra/dpaux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tegra/dpaux.c b/drivers/gpu/drm/tegra/dpaux.c
> index 059f409..2fde44c 100644
> --- a/drivers/gpu/drm/tegra/dpaux.c
> +++ b/drivers/gpu/drm/tegra/dpaux.c
> @@ -539,9 +539,9 @@ static int tegra_dpaux_probe(struct platform_device *pdev)
> dpaux->desc.owner = THIS_MODULE;
>
> dpaux->pinctrl = devm_pinctrl_register(&pdev->dev, &dpaux->desc, dpaux);
> - if (!dpaux->pinctrl) {
> + if (IS_ERR(dpaux->pinctrl)) {
> dev_err(&pdev->dev, "failed to register pincontrol\n");
> - return -ENODEV;
> + return PTR_ERR(dpaux->pinctrl);
> }
> #endif
> /* enable and clear all interrupts */
> --
> 1.9.1
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web