Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	"Peter Feuerer" <peter@piie.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro
Date	Thu, 11 Aug 2016 23:40:02 +0200
Message-ID	<s55RM-X3-29@gated-at.bofh.it> (permalink)
References	<s1JXr-6lC-25@gated-at.bofh.it>
X-Original-To	"Baole Ni" <baolex.ni@intel.com>, dvhart@infradead.org, david.vrabel@citrix.com, jgross@suse.com, bhelgaas@google.com, m.chehab@samsung.com, pawel@osciak.com, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com
X-Greylist	delayed 615 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Aug 2016 17:32:07 EDT
MIME-Version	1.0
Content-Type	text/plain; charset="utf-8"
Content-Transfer-Encoding	8BIT
X-Mailer	RainLoop/1.10.0.107
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	44
Organization	linux.* mail to news gateway
X-Original-Cc	platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com
X-Original-Date	Thu, 11 Aug 2016 21:21:48 +0000
X-Original-Message-ID	<95991cb563633df910245c1fa8d83169@mail.piie.net>
X-Original-References	<20160802115136.6059-1-baolex.ni@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1460811

Show key headers only | View raw

2. August 2016 14:29 Uhr, "Baole Ni" <baolex.ni@intel.com> schrieb:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>

Acked-by: Peter Feuerer <peter@piie.net>

> ---
> drivers/platform/x86/acerhdf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/acerhdf.c b/drivers/platform/x86/acerhdf.c
> index 460fa67..a4706dd 100644
> --- a/drivers/platform/x86/acerhdf.c
> +++ b/drivers/platform/x86/acerhdf.c
> @@ -96,13 +96,13 @@ static struct platform_device *acerhdf_dev;
> 
> module_param(kernelmode, uint, 0);
> MODULE_PARM_DESC(kernelmode, "Kernel mode fan control on / off");
> -module_param(interval, uint, 0600);
> +module_param(interval, uint, S_IRUSR | S_IWUSR);
> MODULE_PARM_DESC(interval, "Polling interval of temperature check");
> -module_param(fanon, uint, 0600);
> +module_param(fanon, uint, S_IRUSR | S_IWUSR);
> MODULE_PARM_DESC(fanon, "Turn the fan on above this temperature");
> -module_param(fanoff, uint, 0600);
> +module_param(fanoff, uint, S_IRUSR | S_IWUSR);
> MODULE_PARM_DESC(fanoff, "Turn the fan off below this temperature");
> -module_param(verbose, uint, 0600);
> +module_param(verbose, uint, S_IRUSR | S_IWUSR);
> MODULE_PARM_DESC(verbose, "Enable verbose dmesg output");
> module_param_string(force_bios, force_bios, 16, 0);
> MODULE_PARM_DESC(force_bios, "Force BIOS version and omit BIOS check");
> -- 
> 2.9.2

-- 
thanks,
--peter;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with  macro "Peter Feuerer" <peter@piie.net> - 2016-08-11 23:40 +0200
  Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro Darren Hart <dvhart@infradead.org> - 2016-08-19 22:10 +0200

csiph-web