Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1466642

Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

On Thu, Aug 11, 2016 at 09:21:48PM +0000, Peter Feuerer wrote:
> 2. August 2016 14:29 Uhr, "Baole Ni" <baolex.ni@intel.com> schrieb:
> > I find that the developers often just specified the numeric value
> > when calling a macro which is defined with a parameter for access permission.
> > As we know, these numeric value for access permission have had the corresponding macro,
> > and that using macro can improve the robustness and readability of the code,
> > thus, I suggest replacing the numeric parameter with the macro.
> > 
> > Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> > Signed-off-by: Baole Ni <baolex.ni@intel.com>
> 
> Acked-by: Peter Feuerer <peter@piie.net>

Due to objections elsewhere in the platform drivers subsystem, I have rejected
these patches as a group, leaving it to the authors to make the argument for
inclusion if they disagree with the decision.

-- 
Darren Hart
Intel Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with  macro "Peter Feuerer" <peter@piie.net> - 2016-08-11 23:40 +0200
  Re: [PATCH 0841/1285] Replace numeric parameter like 0444 with macro Darren Hart <dvhart@infradead.org> - 2016-08-19 22:10 +0200

csiph-web