Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1460639

Re: [PATCH] eeprom: at24: check if the chip is functional in probe()

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH] eeprom: at24: check if the chip is functional in probe()
Date 2016-08-11 18:00 +0200
Message-ID <s50yK-5KE-25@gated-at.bofh.it> (permalink)
References <s4H36-I0-109@gated-at.bofh.it> <s4Jez-29X-25@gated-at.bofh.it> <s4ZW2-5uM-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

> >> +     err = at24_read(at24, 0, &c, 1);
> >
> > Can't we do this before registering dummy clients and nvmem registration?
> >
> 
> It should be ok for nvmem, but I'm not sure about the clients:
> at24_translate_offset() will return one of the registered client
> structures and though it should generally work for the first byte (it
> would always be at24->client[0]), it won't be "rock solid" anymore.

Agreed.

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] eeprom: at24: check if the chip is functional in probe() Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2016-08-11 17:20 +0200
  Re: [PATCH] eeprom: at24: check if the chip is functional in probe() Wolfram Sang <wsa@the-dreams.de> - 2016-08-11 18:00 +0200

csiph-web