Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1459032

Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print

Show all headers | View raw

On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:

> These types of error prints are superfluous.  The system will
> pick up on OOM issues and let the user know.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Although, I think we should drop the "mapping" object. We have all the
information in the carveout object to reverse the mapping at cleanup.

Regards,
Bjorn

> ---
>  drivers/remoteproc/remoteproc_core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 5654a81..4914482 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -619,7 +619,6 @@ static int rproc_handle_carveout(struct rproc *rproc,
>  	if (rproc->domain) {
>  		mapping = kzalloc(sizeof(*mapping), GFP_KERNEL);
>  		if (!mapping) {
> -			dev_err(dev, "kzalloc mapping failed\n");
>  			ret = -ENOMEM;
>  			goto dma_free;
>  		}
> -- 
> 2.9.0
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] remoteproc: Allow platform-specific drivers to request resources Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
  [PATCH 4/9] remoteproc: core: New API to add new resources to the resource table Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 4/9] remoteproc: core: New API to add new resources to  the resource table Lee Jones <lee.jones@linaro.org> - 2016-08-04 16:10 +0200
    Re: [PATCH 4/9] remoteproc: core: New API to add new resources to the  resource table loic pallardy <loic.pallardy@st.com> - 2016-08-08 15:50 +0200
      Re: [PATCH 4/9] remoteproc: core: New API to add new resources to  the resource table Lee Jones <lee.jones@linaro.org> - 2016-08-09 14:50 +0200
  [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones <lee.jones@linaro.org> - 2016-08-05 09:40 +0200
  [PATCH 6/9] remoteproc: core: Add function to append a new resource table entry Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
  [PATCH 7/9] remoteproc: core: Add function to over-ride current resource table Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 7/9] remoteproc: core: Add function to over-ride current  resource table loic pallardy <loic.pallardy@st.com> - 2016-08-08 15:50 +0200
      Re: [PATCH 7/9] remoteproc: core: Add function to over-ride current  resource table Lee Jones <lee.jones@linaro.org> - 2016-08-09 14:50 +0200
  [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:40 +0200
      Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones <lee.jones@linaro.org> - 2016-08-09 20:10 +0200
        Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-10 20:20 +0200
  [PATCH 5/9] remoteproc: core: Add function to amend an existing resource table entry Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
  [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:30 +0200
      Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones <lee.jones@linaro.org> - 2016-08-09 20:20 +0200
        Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Suman Anna <s-anna@ti.com> - 2016-08-10 22:20 +0200
  [PATCH 8/9] remoteproc: core: Skip resource table integrity checks if there are amendments Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 8/9] remoteproc: core: Skip resource table integrity  checks if there are amendments Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:50 +0200
  [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking,  spelling and debug prints Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:40 +0200
      Re: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking,  spelling and debug prints Lee Jones <lee.jones@linaro.org> - 2016-08-09 20:20 +0200

csiph-web