Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1459030

Re: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints

From Bjorn Andersson <bjorn.andersson@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints
Date 2016-08-09 19:40 +0200
Message-ID <s4jap-2dp-13@gated-at.bofh.it> (permalink)
References <s2n8t-6ZA-5@gated-at.bofh.it> <s2n8u-6ZA-39@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu 04 Aug 02:21 PDT 2016, Lee Jones wrote:

> Trivial patch to clean up a couple of minor misgivings.
> 
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org>

Although as I hope to stack this series ontop of the auto-boot there
will be some minor conflicts here.

Regards,
Bjorn

> ---
>  drivers/remoteproc/remoteproc_core.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
> index 3566dc9..5654a81 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -457,8 +457,8 @@ static int rproc_handle_trace(struct rproc *rproc, struct fw_rsc_trace *rsc,
>  
>  	rproc->num_traces++;
>  
> -	dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n", name, ptr,
> -						rsc->da, rsc->len);
> +	dev_dbg(dev, "%s added: va %p, da 0x%x, len 0x%x\n",
> +		name, ptr, rsc->da, rsc->len);
>  
>  	return 0;
>  }
> @@ -581,8 +581,8 @@ static int rproc_handle_carveout(struct rproc *rproc,
>  		return -EINVAL;
>  	}
>  
> -	dev_dbg(dev, "carveout rsc: da %x, pa %x, len 0x%x, flags %x\n",
> -			rsc->da, rsc->pa, rsc->len, rsc->flags);
> +	dev_dbg(dev, "carveout rsc: name: %s, da %x, pa %x, len 0x%x, flags %x\n",
> +		rsc->name, rsc->da, rsc->pa, rsc->len, rsc->flags);
>  
>  	carveout = kzalloc(sizeof(*carveout), GFP_KERNEL);
>  	if (!carveout)
> @@ -700,7 +700,7 @@ static rproc_handle_resource_t rproc_loading_handlers[RSC_LAST] = {
>  	[RSC_CARVEOUT] = (rproc_handle_resource_t)rproc_handle_carveout,
>  	[RSC_DEVMEM] = (rproc_handle_resource_t)rproc_handle_devmem,
>  	[RSC_TRACE] = (rproc_handle_resource_t)rproc_handle_trace,
> -	[RSC_VDEV] = NULL, /* VDEVs were handled upon registrarion */
> +	[RSC_VDEV] = NULL, /* VDEVs were handled upon registration */
>  };
>  
>  static rproc_handle_resource_t rproc_vdev_handler[RSC_LAST] = {
> @@ -918,7 +918,7 @@ static void rproc_fw_config_virtio(const struct firmware *fw, void *context)
>  	 * Create a copy of the resource table. When a virtio device starts
>  	 * and calls vring_new_virtqueue() the address of the allocated vring
>  	 * will be stored in the cached_table. Before the device is started,
> -	 * cached_table will be copied into devic memory.
> +	 * cached_table will be copied into device memory.
>  	 */
>  	rproc->cached_table = kmemdup(table, tablesz, GFP_KERNEL);
>  	if (!rproc->cached_table)
> -- 
> 2.9.0
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/9] remoteproc: Allow platform-specific drivers to request resources Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
  [PATCH 4/9] remoteproc: core: New API to add new resources to the resource table Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 4/9] remoteproc: core: New API to add new resources to  the resource table Lee Jones <lee.jones@linaro.org> - 2016-08-04 16:10 +0200
    Re: [PATCH 4/9] remoteproc: core: New API to add new resources to the  resource table loic pallardy <loic.pallardy@st.com> - 2016-08-08 15:50 +0200
      Re: [PATCH 4/9] remoteproc: core: New API to add new resources to  the resource table Lee Jones <lee.jones@linaro.org> - 2016-08-09 14:50 +0200
  [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 9/9] remoteproc: core: Support empty resource tables Lee Jones <lee.jones@linaro.org> - 2016-08-05 09:40 +0200
  [PATCH 6/9] remoteproc: core: Add function to append a new resource table entry Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
  [PATCH 7/9] remoteproc: core: Add function to over-ride current resource table Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 7/9] remoteproc: core: Add function to over-ride current  resource table loic pallardy <loic.pallardy@st.com> - 2016-08-08 15:50 +0200
      Re: [PATCH 7/9] remoteproc: core: Add function to over-ride current  resource table Lee Jones <lee.jones@linaro.org> - 2016-08-09 14:50 +0200
  [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:40 +0200
      Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Lee Jones <lee.jones@linaro.org> - 2016-08-09 20:10 +0200
        Re: [PATCH 3/9] remoteproc: core: Remove pointless OOM print Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-10 20:20 +0200
  [PATCH 5/9] remoteproc: core: Add function to amend an existing resource table entry Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
  [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:30 +0200
      Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Lee Jones <lee.jones@linaro.org> - 2016-08-09 20:20 +0200
        Re: [PATCH 1/9] remoteproc: core: Ensure error message is clear Suman Anna <s-anna@ti.com> - 2016-08-10 22:20 +0200
  [PATCH 8/9] remoteproc: core: Skip resource table integrity checks if there are amendments Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 8/9] remoteproc: core: Skip resource table integrity  checks if there are amendments Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:50 +0200
  [PATCH 2/9] remoteproc: core: Trivial: Improve error checking, spelling and debug prints Lee Jones <lee.jones@linaro.org> - 2016-08-04 11:30 +0200
    Re: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking,  spelling and debug prints Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-09 19:40 +0200
      Re: [PATCH 2/9] remoteproc: core: Trivial: Improve error checking,  spelling and debug prints Lee Jones <lee.jones@linaro.org> - 2016-08-09 20:20 +0200

csiph-web