Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1458837
| From | Catalin Marinas <catalin.marinas@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers |
| Date | 2016-08-09 17:20 +0200 |
| Message-ID | <s4gYV-Rn-3@gated-at.bofh.it> (permalink) |
| References | <s4eaJ-7rr-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Aug 09, 2016 at 03:09:44PM +0300, Grygorii Strashko wrote:
> diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c
> index 0805855..0456e0e 100644
> --- a/drivers/net/ethernet/ti/cpsw.c
> +++ b/drivers/net/ethernet/ti/cpsw.c
> @@ -732,6 +732,7 @@ static void cpsw_rx_handler(void *token, int len, int status)
> netif_receive_skb(skb);
> ndev->stats.rx_bytes += len;
> ndev->stats.rx_packets++;
> + kmemleak_not_leak(new_skb);
> } else {
> ndev->stats.rx_dropped++;
> new_skb = skb;
> @@ -1323,6 +1324,7 @@ static int cpsw_ndo_open(struct net_device *ndev)
> kfree_skb(skb);
> goto err_cleanup;
> }
> + kmemleak_not_leak(skb);
Nitpick: I would add a short comment above the kmemleak_not_leak() calls
on why there is a false positive. Otherwise:
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers Grygorii Strashko <grygorii.strashko@ti.com> - 2016-08-09 14:20 +0200 Re: [PATCH] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers Catalin Marinas <catalin.marinas@arm.com> - 2016-08-09 17:20 +0200 Re: [PATCH] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers Mugunthan V N <mugunthanvnm@ti.com> - 2016-08-10 20:10 +0200
csiph-web