Path: csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!diesel.cu.mi.it!bofh.it!news.nic.it!robomod From: Catalin Marinas Newsgroups: linux.kernel Subject: Re: [PATCH] drivers: net: cpsw: fix kmemleak false-positive reports for sk buffers Date: Tue, 09 Aug 2016 17:20:01 +0200 Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 23 Organization: linux.* mail to news gateway X-Original-Cc: "David S. Miller" , netdev@vger.kernel.org, Mugunthan V N , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org X-Original-Date: Tue, 9 Aug 2016 16:19:37 +0100 X-Original-Message-ID: <20160809151937.GA15447@e104818-lin.cambridge.arm.com> X-Original-References: <20160809120944.23185-1-grygorii.strashko@ti.com> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1458837 On Tue, Aug 09, 2016 at 03:09:44PM +0300, Grygorii Strashko wrote: > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index 0805855..0456e0e 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -732,6 +732,7 @@ static void cpsw_rx_handler(void *token, int len, int status) > netif_receive_skb(skb); > ndev->stats.rx_bytes += len; > ndev->stats.rx_packets++; > + kmemleak_not_leak(new_skb); > } else { > ndev->stats.rx_dropped++; > new_skb = skb; > @@ -1323,6 +1324,7 @@ static int cpsw_ndo_open(struct net_device *ndev) > kfree_skb(skb); > goto err_cleanup; > } > + kmemleak_not_leak(skb); Nitpick: I would add a short comment above the kmemleak_not_leak() calls on why there is a false positive. Otherwise: Acked-by: Catalin Marinas