Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460207

Re: [PATCH] relay: Use per CPU constructs for the relay channel buffer pointers

Show all headers | View raw

On Thu, Aug 11, 2016 at 12:35:40PM +0530, akash.goel@intel.com wrote:
> From: Akash Goel <akash.goel@intel.com>
> 
> relay essentially needs to maintain the per CPU array of channel buffer
> pointers but it manually creates that array.
> Instead its better to avail the per CPU constructs, provided by the
> kernel, to allocate & access the array of pointer to channel buffers.
> 
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Akash Goel <akash.goel@intel.com>

This has the benefit of being a mechnical change and I could not think
of a better way to express the per-cpu indirection.

relay.h should probably include <linux/percpu.h> so that it pulls in
the percpu api explicitly.

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] relay: Use per CPU constructs for the relay channel buffer pointers akash.goel@intel.com - 2016-08-11 09:00 +0200
  Re: [PATCH] relay: Use per CPU constructs for the relay channel  buffer pointers Chris Wilson <chris@chris-wilson.co.uk> - 2016-08-11 09:10 +0200
    [PATCH v2] relay: Use per CPU constructs for the relay channel buffer pointers akash.goel@intel.com - 2016-08-11 11:40 +0200

csiph-web