Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1460126

Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly

Path csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From Thomas Garnier <thgarnie@google.com>
Newsgroups linux.kernel
Subject Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly
Date Thu, 11 Aug 2016 03:20:01 +0200
Message-ID <s4MP7-4rA-3@gated-at.bofh.it> (permalink)
References <s3SMW-1UI-23@gated-at.bofh.it> <s4ppv-6cf-1@gated-at.bofh.it> <s4GA3-f8-91@gated-at.bofh.it> <s4GA3-f8-93@gated-at.bofh.it> <s4GA3-f8-95@gated-at.bofh.it> <s4GA3-f8-97@gated-at.bofh.it> <s4GA3-f8-99@gated-at.bofh.it> <s4GA3-f8-101@gated-at.bofh.it> <s4ILw-1Hq-33@gated-at.bofh.it> <s4J4S-259-37@gated-at.bofh.it> <s4JHA-2k9-31@gated-at.bofh.it> <s4Mcp-3XK-7@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=u3cTPkF6V7w3rlkJbS384td8ZaE2jxTBmsBX1RliTkU=; b=XJOIBHBwWXqxM8P5eUNsIjmJ5vTPkIiya1OWPDowM/GcgerY5fTyzH/dF5T4CkhST4 vK1VnMoB858p4ZaWNs8TKLwsM1ShHF3qqi01wDd7Olz7y/OEPe5FhvTJHuQZbVP6Hb3K N295lGlESUOwfd5njtvkPhiduS39sTxdt6noN5upV7GTgfQlLhGnT2XB1AiHrn1r0wcO 4apKcAQ6g+JoEH+7Kb/2/NdUtvt5ExS44GcIwP1Rjra1/TCgc1fXePnLhThnaDq2SeMd 4WJgE+p/XHP8dvjcDYu2ppDpASg1A18bJrmGiKipgWyNlyWQpztBylptSpRjAHjQTOJp pAkQ==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=u3cTPkF6V7w3rlkJbS384td8ZaE2jxTBmsBX1RliTkU=; b=RMSBU5lRRYJe+RR9N53DWJfRM1qmHBul1rxBXXUYP7PVNsjxVtnJPE/723eNT8uSQi MX3/4b/YummiRUTSI79YS9rU4gKLXeYUNQPorrxWHcYW65FlRYUO64vB+IOpxR6BN8q9 oaITkFpPmq5KoKl1PNkGgYYyBk0n8pjC4uiMIl0fOCj6IkOXKxhZHkKeoDUvBjoauJGN 9+InrzQS1GGAM/Q5loFf0tTq8f99pHnrorxdQobuB8xHo3WDR+4lBII4+S7WJyAddYo7 oIYZuoUTqY16rTb5yTA88lElUTltxVAzoWrN29CHGqzjtVQ7tosdai7om8marINNcjSH ds1g==
X-Gm-Message-State AEkoout5dFtyMSY6tIWhlnLnIS2cauXI/HSqgXFIT5eJNX3lX+9YccZf2sDLdRNl7mCpdCpDAYEGHc+Iii7hZSy6
X-Received by 10.37.57.79 with SMTP id g76mr3118714yba.161.1470878227586; Wed, 10 Aug 2016 18:17:07 -0700 (PDT)
MIME-Version 1.0
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 41
Organization linux.* mail to news gateway
X-Original-Cc Jiri Kosina <jikos@kernel.org>, Borislav Petkov <bp@suse.de>, "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux PM list <linux-pm@vger.kernel.org>, "the arch/x86 maintainers" <x86@kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Yinghai Lu <yinghai@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>, Kees Cook <keescook@chromium.org>, Pavel Machek <pavel@ucw.cz>, Kernel Hardening <kernel-hardening@lists.openwall.com>
X-Original-Date Wed, 10 Aug 2016 18:17:06 -0700
X-Original-Message-ID <CAJcbSZGCL90OygKhSsox_xzQ0xmNV=Jv2WnVT8vEV7UcqgKWTw@mail.gmail.com>
X-Original-References <2206547.eDj3RJQyE5@vostro.rjw.lan> <2010434.TyoHiO9eal@vostro.rjw.lan> <alpine.LNX.2.00.1608100948560.22028@cbobk.fhfr.pm> <1779906.DOHeuFCiDy@vostro.rjw.lan> <alpine.LNX.2.00.1608101517380.22028@cbobk.fhfr.pm> <CAJcbSZHGH8G01zXSE6y9A19ZxFYY0bzeqcfHBEAYZcn8ZeX3+g@mail.gmail.com> <alpine.LNX.2.00.1608101658070.22028@cbobk.fhfr.pm> <20160810163500.GA9424@nazgul.tnic> <CAJZ5v0h_N5KvjUZjDDdoXMP3UoMmyYKOrHUpyGH14EYWMbxvPA@mail.gmail.com> <CAJZ5v0icnK4jBGkmHb7jJFEcusQyjJGYEG8yhOzMDa_hMQSj_w@mail.gmail.com> <alpine.LNX.2.00.1608102358320.22028@cbobk.fhfr.pm> <CAJZ5v0iAuDYZhmXqG12ZtEpQ5FEzP9Wp4a=EqApwwCc1VBvbLg@mail.gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1460126

Show key headers only | View raw

On Wed, Aug 10, 2016 at 5:35 PM, Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Wed, Aug 10, 2016 at 11:59 PM, Jiri Kosina <jikos@kernel.org> wrote:
>> On Wed, 10 Aug 2016, Rafael J. Wysocki wrote:
>>
>>> So I used your .config to generate one for my test machine and with
>>> that I can reproduce.
>>
>> Was that the config I've sent, or did Boris provide one as well? Which one
>> are you able to reproduce with please?
>
> It's the Boris' one.
>
> Moreover, I have found the options that make the difference: unsetting
> CONFIG_PROVE_LOCKING and CONFIG_DEBUG_LOCK_ALLOC (which also will
> unset CONFIG_LOCKDEP AFAICS) in it makes hibernation work again with
> CONFIG_RANDOMIZE_MEMORY set and with the $subject patch applied.
>
> Unbelievable, but that's what I'm seeing.

Nice find!

>
> Now, that leads to a few questions:
>
> - How does lockdep change the picture so it matters for hibernation?
> - Why is hibernation the only piece that's affected?
> - Why is RANDOMIZE_MEMORY necessary to make this breakage show up?
>
> Thomas, any ideas?

No idea so far. I will investigate though.

We had an unrelated issue with CONFIG_DEBUG_PAGEALLOC on early boot. I
don't think it was related because it was on early boot and with
certain e820 memory layout (and PUD randomization that I disabled on
the previous patch test). The fix is on tip:
http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=fb754f958f8e46202c1efd7f66d5b3db1208117d

>
> Thanks,
> Rafael

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-08 15:30 +0200
  Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Borislav Petkov <bp@suse.de> - 2016-08-08 15:50 +0200
    Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-08 16:00 +0200
      Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-08 20:10 +0200
        Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-08 22:10 +0200
      Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 13:50 +0200
  Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 11:30 +0200
    Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 14:00 +0200
      Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 15:00 +0200
        Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 15:40 +0200
          Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 17:10 +0200
            Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 18:20 +0200
              Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-09 18:30 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 23:00 +0200
              Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 22:10 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 23:30 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-10 02:20 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-10 20:40 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-11 00:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-11 00:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-10 21:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Borislav Petkov <bp@suse.de> - 2016-08-10 21:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-10 23:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-10 23:20 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-11 00:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-11 02:40 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-11 03:20 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-11 03:40 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-11 20:50 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-11 23:30 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-11 23:40 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-10 21:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-10 22:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-10 22:50 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-10 22:10 +0200

csiph-web