Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1458206

Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly

Show all headers | View raw

On Mon, Aug 8, 2016 at 8:00 PM, Thomas Garnier <thgarnie@google.com> wrote:
> On Mon, Aug 8, 2016 at 6:54 AM, Rafael J. Wysocki <rafael@kernel.org> wrote:
>> On Mon, Aug 8, 2016 at 3:40 PM, Borislav Petkov <bp@suse.de> wrote:
>>> On Mon, Aug 08, 2016 at 03:31:31PM +0200, Rafael J. Wysocki wrote:
>>>> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>>
>>>> The low-level resume-from-hibernation code on x86-64 uses
>>>> kernel_ident_mapping_init() to create the temoprary identity mapping,
>>>> but that function assumes that the offset between kernel virtual
>>>> addresses and physical addresses is aligned on the PGD level.
>>>>
>>>> However, with a randomized identity mapping base, it may be aligned
>>>> on the PUD level and if that happens, the temporary identity mapping
>>>> created by set_up_temporary_mappings() will not reflect the actual
>>>> kernel identity mapping and the image restoration will fail as a
>>>> result (leading to a kernel panic most of the time).
>>>>
>>>> To fix this problem, rework kernel_ident_mapping_init() to support
>>>> unaligned offsets between KVA and PA up to the PMD level and make
>>>> set_up_temporary_mappings() use it as approprtiate.
>>>>
>>>> Reported-by: Thomas Garnier <thgarnie@google.com>
>>>
>>> Reported-by: Borislav Petkov <bp@suse.de>
>>>
>>>> Suggested-by: Yinghai Lu <yinghai@kernel.org>
>>>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>> Acked-by: Yinghai Lu <yinghai@kernel.org>
>>>> ---
>>>>
>>>> This is sort of urgent, because hibernation doesn't work with KASLR on x86-64
>>>> in 4.8-rc1 AFAICS and this should make them work together again.
>>>>
>>>> Unless anyone sees any problems with it, I'll queue it up for 4.8-rc2.
>>>>
>>>> Thomas, would it be possible to test it with KASLR enabled, please?
>>>
>
> I tested it on my setup couple times. Worked well.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-08 15:30 +0200
  Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Borislav Petkov <bp@suse.de> - 2016-08-08 15:50 +0200
    Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-08 16:00 +0200
      Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-08 20:10 +0200
        Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-08 22:10 +0200
      Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 13:50 +0200
  Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 11:30 +0200
    Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 14:00 +0200
      Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 15:00 +0200
        Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 15:40 +0200
          Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 17:10 +0200
            Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 18:20 +0200
              Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-09 18:30 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 23:00 +0200
              Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-09 22:10 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-09 23:30 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-10 02:20 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-10 20:40 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-10 21:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Borislav Petkov <bp@suse.de> - 2016-08-10 21:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-10 23:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly "Rafael J. Wysocki" <rafael@kernel.org> - 2016-08-10 23:20 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-10 21:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Thomas Garnier <thgarnie@google.com> - 2016-08-10 22:00 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity  mapping correctly Jiri Kosina <jikos@kernel.org> - 2016-08-10 22:50 +0200
                Re: [Resend][PATCH] x86/power/64: Always create temporary identity mapping correctly "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-08-10 22:10 +0200

csiph-web