Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1456602

Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG
Date 2016-08-04 19:30 +0200
Message-ID <s2uCZ-41d-7@gated-at.bofh.it> (permalink)
References <s1ypj-786-3@gated-at.bofh.it> <s1ypj-786-11@gated-at.bofh.it> <s2srw-2sp-27@gated-at.bofh.it> <s2uCZ-41d-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Thu, Aug 04, 2016 at 10:23:43AM -0700, David Carrillo-Cisneros wrote:
> >> Introduce the flag PMUEF_READ_CPU_PKG, useful for uncore events, that
> >> allows a PMU to signal the generic perf code that an event is readable
> >> on the current CPU if the event is:
> >>   - active in a CPU in the same package as the current CPU (local CPU)
> >
> > Ok that I get..
> >
> >>   - not active but is attached to a CPU (i.e. event->cpu != -1) in the
> >>   same package as the current CPU.
> >
> > but this, not so much. Why would you want to read an inactive counter?
> 
> Uncore counters are active even if its event is not.

Not in general they are not, and if they are (freerunning msr counters
for example) we should not include the counts when the event is
inactive.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] remove unnecessary IPI reading uncore events David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 05:20 +0200
  [PATCH 3/3] perf/x86: use PMUEF_READ_CPU_PKG in uncore events David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 05:20 +0200
  [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 05:20 +0200
    Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 17:10 +0200
      Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-04 19:30 +0200
    Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 17:10 +0200
      Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 19:30 +0200
        Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-04 19:50 +0200
      Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-04 19:40 +0200
    Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 17:50 +0200
  [PATCH 1/3] perf/core: check return value of perf_event_read IPI David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 06:40 +0200
  Re: [PATCH 0/3] remove unnecessary IPI reading uncore events Andi Kleen <ak@linux.intel.com> - 2016-08-02 17:30 +0200

csiph-web