Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1456505

Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG

From Peter Zijlstra <peterz@infradead.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG
Date 2016-08-04 17:50 +0200
Message-ID <s2t4e-2PF-25@gated-at.bofh.it> (permalink)
References <s1ypj-786-3@gated-at.bofh.it> <s1ypj-786-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 01, 2016 at 07:44:54PM -0700, David Carrillo-Cisneros wrote:
> +/*
> + * Flags for pmu_event_flags.
> + *
> + * PMUEF_READ_CPU_PKG: A CPU event (or cgroup event) that can be read in
> + *     any CPU in event->cpu's package, even if inactive.
> + */
> +#define PMUEF_READ_CPU_PKG		BIT(0)

So I don't object to the idea, but this flags thing seems somewhat
awkward to express 'random' topology constraints.

For example, the AMD Fam15 NB driver could use something similar, but
I'm not sure their NB-id matches our topo package id.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] remove unnecessary IPI reading uncore events David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 05:20 +0200
  [PATCH 3/3] perf/x86: use PMUEF_READ_CPU_PKG in uncore events David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 05:20 +0200
  [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 05:20 +0200
    Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 17:10 +0200
      Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-04 19:30 +0200
    Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 17:10 +0200
      Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 19:30 +0200
        Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-04 19:50 +0200
      Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros <davidcc@google.com> - 2016-08-04 19:40 +0200
    Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and  PMUEF_READ_CPU_PKG Peter Zijlstra <peterz@infradead.org> - 2016-08-04 17:50 +0200
  [PATCH 1/3] perf/core: check return value of perf_event_read IPI David Carrillo-Cisneros <davidcc@google.com> - 2016-08-02 06:40 +0200
  Re: [PATCH 0/3] remove unnecessary IPI reading uncore events Andi Kleen <ak@linux.intel.com> - 2016-08-02 17:30 +0200

csiph-web