Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()

Path	csiph.com!goblin3!goblin1!goblin2!goblin.stu.neva.ru!news.unit0.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()
Date	Thu, 04 Aug 2016 12:40:02 +0200
Message-ID	<s2oee-7FS-27@gated-at.bofh.it> (permalink)
References	<s1E1I-2tq-15@gated-at.bofh.it>
X-Original-To	Sebastian Frias <sf84@laposte.net>
User-Agent	Alpine 2.20 (DEB 67 2015-01-07)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Grant Likely <grant.likely@secretlab.ca>, Marc Zyngier <marc.zyngier@arm.com>, Jason Cooper <jason@lakedaemon.net>, LKML <linux-kernel@vger.kernel.org>, Mason <slash.tmp@free.fr>
X-Original-Date	Thu, 4 Aug 2016 12:05:35 +0200 (CEST)
X-Original-Message-ID	<alpine.DEB.2.20.1608041146540.5547@nanos>
X-Original-References	<57A063B8.5050209@laposte.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1456319

Show key headers only | View raw

On Tue, 2 Aug 2016, Sebastian Frias wrote:

> Use IRQ_TYPE_SENSE_MASK on irq_domain_xlate_onetwocell()
> 
> According to the xlate() callback definition, the 'out_type' parameter
> needs to be the "linux irq type". A mask for such bits exists,
> IRQ_TYPE_SENSE_MASK, and as a matter of fact it is used in
> irq_domain_xlate_twocell(), use it for irq_domain_xlate_onetwocell() as
> well.
> 
> Fixes: 16b2e6e2f31d ("irq_domain: Create common xlate functions that device
> drivers can use")

You seem to be obsessed by adding "Fixes" tags and 'Fix' to the $subject, but
your changelog just babbles about making the code the same as in
irq_domain_xlate_twocell() and avoids carefully to explain what is broken,
what consequences that has and what the fix is.

Now if you look at the call site which uses the xlate functions then you'll
notice that we have a sanity check there already:

        if (irq_domain_translate(domain, fwspec, &hwirq, &type))
                return 0;
        /*
         * WARN if the irqchip returns a type with bits
         * outside the sense mask set and clear these bits.
         */
        if (WARN_ON(type & ~IRQ_TYPE_SENSE_MASK))
                type &= IRQ_TYPE_SENSE_MASK;

So we better remove the masking in the xlate functions completely and let all
the offending device trees trip over the warning so they get eventually fixed.

Thanks,

	tglx

Thread

[PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Sebastian Frias <sf84@laposte.net> - 2016-08-02 11:20 +0200
  Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Thomas Gleixner <tglx@linutronix.de> - 2016-08-04 12:40 +0200
    Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Sebastian Frias <sf84@laposte.net> - 2016-08-04 12:40 +0200
      Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Thomas Gleixner <tglx@linutronix.de> - 2016-08-04 16:40 +0200

csiph-web