Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell()
Date	2016-08-04 16:40 +0200
Message-ID	<s2rYt-20R-9@gated-at.bofh.it> (permalink)
References	<s1E1I-2tq-15@gated-at.bofh.it> <s2oee-7FS-27@gated-at.bofh.it> <s2oee-7FS-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 4 Aug 2016, Sebastian Frias wrote:
> On 08/04/2016 12:05 PM, Thomas Gleixner wrote:
> (for what is worth, my patch was based on a recent 4.7 that does not has the
> code you mention above)

In future, please always check against mainline or the head of the relevant
maintainer tree.

> > So we better remove the masking in the xlate functions completely and let all
> > the offending device trees trip over the warning so they get eventually fixed.
> 
> That's fine by me.
> If you want I can submit a patch that does what you want (if so, should I use
> "fixes" or not?), let me know.

If it is broken then it wants a fixes tag plus an explanation WHY it is
broken, what consequences the breakage has etc.

If it's just a regular code improvement then not.

Decide yourself.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Sebastian Frias <sf84@laposte.net> - 2016-08-02 11:20 +0200
  Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Thomas Gleixner <tglx@linutronix.de> - 2016-08-04 12:40 +0200
    Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Sebastian Frias <sf84@laposte.net> - 2016-08-04 12:40 +0200
      Re: [PATCH 1/2] irqdomain: fix irq_domain_xlate_onetwocell() Thomas Gleixner <tglx@linutronix.de> - 2016-08-04 16:40 +0200

csiph-web