Re: [RFC 2/4] bpf, security: Add Checmate

From	Sargun Dhillon <sargun@sargun.me>
Newsgroups	linux.kernel
Subject	Re: [RFC 2/4] bpf, security: Add Checmate
Date	2016-08-05 09:20 +0200
Message-ID	<s2HAd-4mE-11@gated-at.bofh.it> (permalink)
References	<s2l6F-5K2-11@gated-at.bofh.it> <s2lT4-6gd-7@gated-at.bofh.it> <s2mcp-6oY-11@gated-at.bofh.it> <s2nia-73p-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 04, 2016 at 05:34:32PM +0800, zhuyj wrote:
>  Sure.
> Is it better to add
> #ifndef CONFIG_PREEMPT_RCU ?
> 
> On Thu, Aug 4, 2016 at 4:28 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> > Please do not top post
> >
> > On Thu, 2016-08-04 at 16:08 +0800, zhuyj wrote:
> >>  +void register_checmate_prog_ops(void);
> >> maybe it is extern void register_checmate_prog_ops(void);?
> >>
> >> +       preempt_disable();
> >> +       rcu_read_lock();
> >> IMHO, it is not necessary to use the above 2 since rcu_read_lock will
> >> call preempt_disable.
> >
> > You might double check if this claim is true if CONFIG_PREEMPT_RCU=y
> >
> >
> >
Thanks for your feedback zhuyj, Looking at kernel documentation itself, it looks 
like this is the preferred mechanism[1]. Their example:

 1 preempt_disable();
 2 rcu_read_lock();
 3 do_something();
 4 rcu_read_unlock();
 5 preempt_enable();

But, I think you're right. Do you know if there's a great benefit of doing this? 
Or does it make sense to implement a new macro, a la 
rcu_read_lock_and_preent_disable()?

[1] https://www.kernel.org/doc/Documentation/RCU/Design/Requirements/Requirements.html#Disabling Preemption Does Not Block Grace Periods

Thread

[RFC 2/4] bpf, security: Add Checmate Sargun Dhillon <sargun@sargun.me> - 2016-08-04 09:20 +0200
  Re: [RFC 2/4] bpf, security: Add Checmate zhuyj <zyjzyj2000@gmail.com> - 2016-08-04 10:10 +0200
    Re: [RFC 2/4] bpf, security: Add Checmate Eric Dumazet <eric.dumazet@gmail.com> - 2016-08-04 10:30 +0200
      Re: [RFC 2/4] bpf, security: Add Checmate zhuyj <zyjzyj2000@gmail.com> - 2016-08-04 11:40 +0200
        Re: [RFC 2/4] bpf, security: Add Checmate Sargun Dhillon <sargun@sargun.me> - 2016-08-05 09:20 +0200
          Re: [RFC 2/4] bpf, security: Add Checmate zhuyj <zyjzyj2000@gmail.com> - 2016-08-05 09:50 +0200

csiph-web