Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1456868
| From | Andy Gross <andy.gross@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 |
| Date | 2016-08-05 06:10 +0200 |
| Message-ID | <s2ECl-2yr-3@gated-at.bofh.it> (permalink) |
| References | <rTRp8-4gA-23@gated-at.bofh.it> <rTRp8-4gA-31@gated-at.bofh.it> <rTSbw-4P8-17@gated-at.bofh.it> <s2BEu-qb-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Aug 04, 2016 at 05:58:26PM -0700, Stephen Boyd wrote:
> On 07/11, Andy Gross wrote:
> > On Mon, Jul 11, 2016 at 02:50:07PM -0700, Stephen Boyd wrote:
> >
> > > static const struct regulator_desc pm8941_pldo = {
> > > .linear_ranges = (struct regulator_linear_range[]) {
> > > - REGULATOR_LINEAR_RANGE( 750000, 0, 30, 25000),
> > > - REGULATOR_LINEAR_RANGE(1500000, 31, 99, 50000),
> > > + REGULATOR_LINEAR_RANGE( 750000, 0, 63, 12500),
> > > + REGULATOR_LINEAR_RANGE(1550000, 64, 126, 25000),
> > > + REGULATOR_LINEAR_RANGE(3100000, 127, 163, 50000),
> > > },
> > > - .n_linear_ranges = 2,
> > > - .n_voltages = 100,
> > > + .n_linear_ranges = 3,
> > > + .n_voltages = 164,
> > > .ops = &rpm_smps_ldo_ops,
> > > };
> >
> > Still a little confused on if the 12.5mV is allowed on pmos ldo. It seems like the
> > nmos has 1 range of 5mV steps. The PMOS has 2 ranges, using 25mV and 50mV
> >
>
> The values I've put in these patches are the correct ranges.
Ok. As with the other patch:
Reviewed-by: Andy Gross <andy.gross@linaro.org>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Stephen Boyd <sboyd@codeaurora.org> - 2016-08-05 03:00 +0200 Re: [PATCH 1/3] regulator: qcom_smd: Fix voltage ranges for pm8x41 Andy Gross <andy.gross@linaro.org> - 2016-08-05 06:10 +0200
csiph-web