Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns

From	ebiederm@xmission.com (Eric W. Biederman)
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns
Date	2016-08-03 19:50 +0200
Message-ID	<s28sN-5FV-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <s25lg-3EJ-29@gated-at.bofh.it> <s25XX-47e-3@gated-at.bofh.it> <s25XX-47e-1@gated-at.bofh.it> <s267E-4aR-23@gated-at.bofh.it> <s267E-4aR-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Nikolay Borisov <kernel@kyup.com> writes:

> On 08/03/2016 06:06 PM, J. Bruce Fields wrote:
>> Digging around...  Oh, I see, there's an optional 'lock:..' line in
>> /proc/[pid]/fdinfo/[pid] file, is that what you're looking at?  I'd
>> forgotten.  Yeah, maybe that would make more sense long term.
>
> Yep, that's the one but this requires the userspace to be updated to use
> that interface. In the meantime we could do away with some maintenance
> of the existing /proc/locks :)

I am tempted to say let's not change /proc/locks at all, but if locks
really are in a pid namespace than I do think it makes sense to filter
them in /proc just so there is not excessive visiblity outside of the
pid namespace.

Excessive visibility is a problem on it's own.

Eric

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH] locks: Show only file_locks created in the same pidns as current process Nikolay Borisov <kernel@kyup.com> - 2016-08-02 17:00 +0200
  Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 17:10 +0200
    Re: [RFC PATCH] locks: Show only file_locks created in the same pidns  as current process Nikolay Borisov <kernel@kyup.com> - 2016-08-02 17:50 +0200
      Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 18:40 +0200
  Re: [RFC PATCH] locks: Show only file_locks created in the same pidns as current process ebiederm@xmission.com (Eric W. Biederman) - 2016-08-02 18:20 +0200
    Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 19:50 +0200
      Re: [RFC PATCH] locks: Show only file_locks created in the same pidns as current process ebiederm@xmission.com (Eric W. Biederman) - 2016-08-02 21:30 +0200
        Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 22:00 +0200
          Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process Jeff Layton <jlayton@poochiereds.net> - 2016-08-02 22:10 +0200
            Re: [RFC PATCH] locks: Show only file_locks created in the same pidns  as current process Nikolay Borisov <kernel@kyup.com> - 2016-08-02 22:20 +0200
            Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 22:50 +0200
  [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 10:00 +0200
    Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Jeff Layton <jlayton@poochiereds.net> - 2016-08-03 15:50 +0200
      Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-03 16:30 +0200
        Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 16:40 +0200
      Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 16:30 +0200
        Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 17:10 +0200
          Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-03 17:20 +0200
            Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 17:20 +0200
              Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns ebiederm@xmission.com (Eric W. Biederman) - 2016-08-03 19:50 +0200

csiph-web