Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455853

Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns

Show all headers | View raw

On Wed, Aug 03, 2016 at 06:00:18PM +0300, Nikolay Borisov wrote:
> 
> 
> On 08/03/2016 05:54 PM, Pavel Emelyanov wrote:
> > On 08/03/2016 05:17 PM, Nikolay Borisov wrote:
> >>
> >>
> [SNIP]
> >>
> >> [CCing some people from openvz/CRIU]
> > 
> > Thanks :)
> > 
> >> My train of thought was "we should have means which would be the one
> >> universal truth about everything and this would be a process in the
> >> init_pid_ns". I don't have strong preference as long as I'm not breaking
> >> userspace. As I said before - I think the CRIU guys might be using that
> >> interface.
> > 
> > This particular change won't break us mostly because we've switched to
> > reading the /proc/pid/fdinfo/n files for locks.
> 
> [thinking out loud here]
> 
> I've never actually looked into those files but now that I have it seems
> to make sense to also switch 'lsof' to actually reading the locks from
> the available pids directories rather than relying on the global
> /proc/locks interface. Oh well :)

Digging around...  Oh, I see, there's an optional 'lock:..' line in
/proc/[pid]/fdinfo/[pid] file, is that what you're looking at?  I'd
forgotten.  Yeah, maybe that would make more sense long term.

--b.

> 
> [/thinking out loud here]
> 
> > 
> > -- Pavel
> > 
> >>>
> >>>>>> +	    && (proc_pidns != ns_of_pid(fl->fl_nspid)))
> >>>>> +		return 0;
> >>>> +
> >>>>>  	lock_get_status(f, fl, iter->li_pos, "");
> >>>>  
> >>>>>  	list_for_each_entry(bfl, &fl->fl_block, fl_block)
> >>>
> >> .
> >>
> > 
> > _______________________________________________
> > Containers mailing list
> > Containers@lists.linux-foundation.org
> > https://lists.linuxfoundation.org/mailman/listinfo/containers
> > 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] locks: Show only file_locks created in the same pidns as current process Nikolay Borisov <kernel@kyup.com> - 2016-08-02 17:00 +0200
  Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 17:10 +0200
    Re: [RFC PATCH] locks: Show only file_locks created in the same pidns  as current process Nikolay Borisov <kernel@kyup.com> - 2016-08-02 17:50 +0200
      Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 18:40 +0200
  Re: [RFC PATCH] locks: Show only file_locks created in the same pidns as current process ebiederm@xmission.com (Eric W. Biederman) - 2016-08-02 18:20 +0200
    Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 19:50 +0200
      Re: [RFC PATCH] locks: Show only file_locks created in the same pidns as current process ebiederm@xmission.com (Eric W. Biederman) - 2016-08-02 21:30 +0200
        Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 22:00 +0200
          Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process Jeff Layton <jlayton@poochiereds.net> - 2016-08-02 22:10 +0200
            Re: [RFC PATCH] locks: Show only file_locks created in the same pidns  as current process Nikolay Borisov <kernel@kyup.com> - 2016-08-02 22:20 +0200
            Re: [RFC PATCH] locks: Show only file_locks created in the same  pidns as current process "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-02 22:50 +0200
  [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 10:00 +0200
    Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Jeff Layton <jlayton@poochiereds.net> - 2016-08-03 15:50 +0200
      Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-03 16:30 +0200
        Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 16:40 +0200
      Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 16:30 +0200
        Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 17:10 +0200
          Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns "J. Bruce Fields" <bfields@fieldses.org> - 2016-08-03 17:20 +0200
            Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov <kernel@kyup.com> - 2016-08-03 17:20 +0200
              Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns ebiederm@xmission.com (Eric W. Biederman) - 2016-08-03 19:50 +0200

csiph-web