Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1455933
| From | Guenter Roeck <groeck@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) |
| Date | 2016-08-03 20:10 +0200 |
| Message-ID | <s28Ma-62m-21@gated-at.bofh.it> (permalink) |
| References | <s1ODL-16D-3@gated-at.bofh.it> <s1ODM-16D-23@gated-at.bofh.it> <s20EW-Iw-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Aug 3, 2016 at 2:18 AM, Oliver Neukum <oneukum@suse.com> wrote:
> On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
>> +static int tcpm_set_polarity(struct tcpm_port *port,
>> + enum typec_cc_polarity polarity)
>> +{
>> + tcpm_log(port, "polarity %d", polarity);
>> +
>> + port->polarity = polarity;
>> +
>> + return port->tcpc->set_polarity(port->tcpc, port->polarity);
>> +}
>
> Here you don't care about the result.
Changed to only set port->polarity if the set_polarity callback was successful.
Thanks,
Guenter
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 0/4] Type-C Port Manager Guenter Roeck <groeck@chromium.org> - 2016-08-02 22:40 +0200
[RFC PATCH 4/4] usb: typec: Type-C Port Controller Interface driver (tcpci) Guenter Roeck <groeck@chromium.org> - 2016-08-02 22:40 +0200
Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Oliver Neukum <oneukum@suse.com> - 2016-08-03 11:30 +0200
Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-08-03 20:10 +0200
Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Oliver Neukum <oneukum@suse.com> - 2016-08-03 11:40 +0200
Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-08-03 20:50 +0200
csiph-web