Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455710

Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm)

Show all headers | View raw

On Tue, 2016-08-02 at 13:32 -0700, Guenter Roeck wrote:
> +static int tcpm_set_polarity(struct tcpm_port *port,
> +                            enum typec_cc_polarity polarity)
> +{
> +       tcpm_log(port, "polarity %d", polarity);
> +
> +       port->polarity = polarity;
> +
> +       return port->tcpc->set_polarity(port->tcpc, port->polarity);
> +}

Here you don't care about the result.

> +
> +static int tcpm_set_vconn(struct tcpm_port *port, bool enable)
> +{
> +       int ret = 0;
> +
> +       tcpm_log(port, "vconn:=%d", enable);
> +
> +       ret = port->tcpc->set_vconn(port->tcpc, enable);
> +       if (!ret) {
> +               port->con.vconn_role = enable ? TYPEC_SOURCE
> +                                             : TYPEC_SINK;
> +               typec_set_vconn_role(port->typec_port,
> port->con.vconn_role);
> +       }
> +
> +       return ret;
> +}

But here you do. Which is right?

	Regards
		Oliver

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH 0/4] Type-C Port Manager Guenter Roeck <groeck@chromium.org> - 2016-08-02 22:40 +0200
  [RFC PATCH 4/4] usb: typec: Type-C Port Controller Interface driver (tcpci) Guenter Roeck <groeck@chromium.org> - 2016-08-02 22:40 +0200
  Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Oliver Neukum <oneukum@suse.com> - 2016-08-03 11:30 +0200
    Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-08-03 20:10 +0200
  Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Oliver Neukum <oneukum@suse.com> - 2016-08-03 11:40 +0200
    Re: [RFC PATCH 3/4] usb: typec: USB Type-C Port Manager (tcpm) Guenter Roeck <groeck@google.com> - 2016-08-03 20:50 +0200

csiph-web