Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455875

Re: [PATCH v0 3/4] i2c: brcmstb: Use complete() instead of complete_all()

Show all headers | View raw

LGTM

On Wed, Aug 3, 2016 at 8:03 AM, Daniel Wagner <wagi@monom.org> wrote:
> From: Daniel Wagner <daniel.wagner@bmw-carit.de>
>
> There is only one waiter for the completion, therefore there
> is no need to use complete_all(). Let's make that clear by
> using complete() instead of complete_all().
>
> The usage pattern of the completion is:
>
> brcmstb_send_i2c_cmd()
>   reinit_completion()
>   ...
>   /* initiate transfer by setting iic_enable */
>   ...
>   brcmstb_i2c_wait_for_completion()
>
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>

Reviewed-by: Kamal Dasu <kdasu.kdev@gmail.com>

> ---
>  drivers/i2c/busses/i2c-brcmstb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-brcmstb.c b/drivers/i2c/busses/i2c-brcmstb.c
> index 6a8cfc1..ab4ff96 100644
> --- a/drivers/i2c/busses/i2c-brcmstb.c
> +++ b/drivers/i2c/busses/i2c-brcmstb.c
> @@ -228,7 +228,7 @@ static irqreturn_t brcmstb_i2c_isr(int irq, void *devid)
>                 return IRQ_NONE;
>
>         brcmstb_i2c_enable_disable_irq(dev, INT_DISABLE);
> -       complete_all(&dev->done);
> +       complete(&dev->done);
>
>         dev_dbg(dev->device, "isr handled");
>         return IRQ_HANDLED;
> --
> 2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v0 3/4] i2c: brcmstb: Use complete() instead of complete_all() Daniel Wagner <wagi@monom.org> - 2016-08-03 14:20 +0200
  Re: [PATCH v0 3/4] i2c: brcmstb: Use complete() instead of complete_all() Kamal Dasu <kdasu.kdev@gmail.com> - 2016-08-03 18:10 +0200

csiph-web