Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453508

[PATCH] ASoC: simple-card: fix module load "unknown symbol" issue

Show all headers | View raw

An ASoC driver using simple-card, when built as a module gets the
following error at module load time:

[   23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0)
[   23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0)

fix this by including simple-card-utils.o symbols in the module build
its symols are resolved correctly.

Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp,
with all of ASoC built as modules.

Cc: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
---
 sound/soc/generic/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile
index 45602ca8536e..ff0c55eee4f7 100644
--- a/sound/soc/generic/Makefile
+++ b/sound/soc/generic/Makefile
@@ -2,4 +2,8 @@ obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o
 
 snd-soc-simple-card-objs	:= simple-card.o
 
+ifneq ($(CONFIG_SND_SIMPLE_CARD_UTILS),)
+snd-soc-simple-card-objs	+=  simple-card-utils.o
+endif
+
 obj-$(CONFIG_SND_SIMPLE_CARD)	+= snd-soc-simple-card.o
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman <khilman@baylibre.com> - 2016-08-02 01:50 +0200
  Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman <khilman@baylibre.com> - 2016-08-02 04:50 +0200
    Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Mark Brown <broonie@kernel.org> - 2016-08-02 20:20 +0200
    Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Kevin Hilman <khilman@baylibre.com> - 2016-08-02 21:00 +0200
      Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Mark Brown <broonie@kernel.org> - 2016-08-02 21:50 +0200
  Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori <nsekhar@ti.com> - 2016-08-08 16:20 +0200
    Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori <nsekhar@ti.com> - 2016-08-09 08:50 +0200

csiph-web