Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()
Date	2016-08-02 20:20 +0200
Message-ID	<s1Msj-88r-77@gated-at.bofh.it> (permalink)
References	<s1v85-4Pg-1@gated-at.bofh.it> <s1xWh-6Jw-3@gated-at.bofh.it> <s1xWh-6Jw-1@gated-at.bofh.it> <s1Msj-88r-79@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 02, 2016 at 03:22:08AM +0000, Kuninori Morimoto wrote:

> +MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
> +MODULE_DESCRIPTION("ALSA SoC Simple Card Utils");
> +MODULE_LICENSE("GPL v2");

This lot is what is needed (well, just the MODULE_LICENSE).

> +MODULE_ALIAS("platform:asoc-simple-card-utils");

This is wrong, this isn't a driver but rather a library that's used by
other modules so it shouldn't have an alias.  The aliases are there to
let modutils know which module to load for a device that it sees.

Thread

[PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman <khilman@baylibre.com> - 2016-08-02 01:50 +0200
  Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman <khilman@baylibre.com> - 2016-08-02 04:50 +0200
    Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Mark Brown <broonie@kernel.org> - 2016-08-02 20:20 +0200
    Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Kevin Hilman <khilman@baylibre.com> - 2016-08-02 21:00 +0200
      Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Mark Brown <broonie@kernel.org> - 2016-08-02 21:50 +0200
  Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori <nsekhar@ti.com> - 2016-08-08 16:20 +0200
    Re: [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori <nsekhar@ti.com> - 2016-08-09 08:50 +0200

csiph-web