Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1453431

Re: Fixup direct bi_rw modifiers

Show all headers | View raw

On 08/01/2016 09:17 AM, Jens Axboe wrote:
> On 08/01/2016 05:47 AM, Christoph Hellwig wrote:
>> On Sat, Jul 30, 2016 at 04:45:48PM -0500, Shaun Tancheff wrote:
>>> bi_rw should be using bio_set_op_attrs to set bi_rw.
>>
>> Looks fine,
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Added, thanks Shaun.
>
>> Jens,
>>
>> what do you think about renaming bi_rw?  There aren't too many users
>> left, and any old code that would keep using it is alsmost guranteed
>> to be broken, so sending a post-rc1 patch to rename it might make
>> everyone else life easier.  Especially as it's also grossly misnamed
>> now.
>
> I was planning on doing that, after -rc1. Much better to get build
> breakage, than potentially much worse breakage.

Set of three patches, where the target one is an actual bug fix...
Temporary branch, I'll rebase it once -rc1 is out, if more
changes/fixups need to be made in the next week until that happens.

http://git.kernel.dk/cgit/linux-block/log/?h=for-4.8/bi_rwf

-- 
Jens Axboe

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Fixup direct bi_rw modifiers Shaun Tancheff <shaun@tancheff.com> - 2016-07-30 23:50 +0200
  Re: Fixup direct bi_rw modifiers Christoph Hellwig <hch@infradead.org> - 2016-08-01 13:50 +0200
    Re: Fixup direct bi_rw modifiers Jens Axboe <axboe@kernel.dk> - 2016-08-01 17:30 +0200
      Re: Fixup direct bi_rw modifiers Jens Axboe <axboe@kernel.dk> - 2016-08-01 22:00 +0200
        Re: Fixup direct bi_rw modifiers Christoph Hellwig <hch@infradead.org> - 2016-08-02 14:40 +0200
          Re: Fixup direct bi_rw modifiers Jens Axboe <axboe@kernel.dk> - 2016-08-02 20:10 +0200

csiph-web