Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1453038
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ |
| Date | 2016-08-01 10:40 +0200 |
| Message-ID | <s1gVs-3TO-9@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <rHqXn-4lt-23@gated-at.bofh.it> <s077P-7Eh-5@gated-at.bofh.it> <s0bbs-24M-23@gated-at.bofh.it> <s1amZ-7Vp-1@gated-at.bofh.it> <s1g93-3mB-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Marc, 2016-08-01 16:46 GMT+09:00 Marc Zyngier <marc.zyngier@arm.com>: > On 01/08/16 02:28, Masahiro Yamada wrote: >> 2016-07-29 17:10 GMT+09:00 Marc Zyngier <marc.zyngier@arm.com>: >>> On 29/07/16 04:53, Masahiro Yamada wrote: >>>> Hi. >>>> >>>> >>>> I noticed my board would not work any more >>>> when pulling recent updates. >>>> >>>> >>>> I did "git-bisect" and I found the following commit is it. >>> >>> It would help if you did post the log showing the failure. >>> >>> What if you apply the following patch: >>> >>> https://git.kernel.org/cgit/linux/kernel/git/maz/arm-platforms.git/diff/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi?h=timers/level-trigger&id=95e1fd920fcadce81626cfa9bd6af1a361f17e58 >>> >> >> Hi Mark, >> >> Yes, it worked. >> >> But I did not understand why you changed the 3rd cell to 0xf08. >> >> >> The binding of arm,gic-v3.txt says as follows: >> >> >> The 3rd cell is the flags, encoded as follows: >> bits[3:0] trigger type and level flags. >> 1 = edge triggered >> 4 = level triggered >> >> >> Only 1 and 4 are defined for the bits[3:0]. > > Ah, I didn't realize you were using GICv3. > > If you look at the documentation for the A72 timers: > http://infocenter.arm.com/help/topic/com.arm.doc.100095_0003_05_en/way1382454511590.html > > You'll notice that all timers have an active-low output. Switching to > "level triggered" fixes the issue in general. > >> 0xf04 worked, too. >> >> Which is correct? > > None of them. 0x04 is the correct answer (as we don't encode the > affinity in the 3rd cell. Thank you! -- Best Regards Masahiro Yamada
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-29 06:00 +0200
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Marc Zyngier <marc.zyngier@arm.com> - 2016-07-29 10:20 +0200
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 03:40 +0200
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Marc Zyngier <marc.zyngier@arm.com> - 2016-08-01 09:50 +0200
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 10:40 +0200
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Jon Hunter <jonathanh@nvidia.com> - 2016-07-29 10:40 +0200
Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 05:20 +0200
csiph-web