Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1452322

Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ

From Jon Hunter <jonathanh@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ
Date 2016-07-29 10:40 +0200
Message-ID <s0buO-2d6-25@gated-at.bofh.it> (permalink)
References <rHqXn-4lt-15@gated-at.bofh.it> <rHqXn-4lt-23@gated-at.bofh.it> <s077P-7Eh-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 29/07/16 04:53, Masahiro Yamada wrote:
> Hi.
> 
> I noticed my board would not work any more
> when pulling recent updates.
> 
> I did "git-bisect" and I found the following commit is it.
> 
> commit 1e2a7d78499ec8859d2b469051b7b80bad3b08aa
> Author: Jon Hunter <jonathanh@nvidia.com>
> Date:   Tue Jun 7 16:12:28 2016 +0100
> 
>     irqdomain: Don't set type when mapping an IRQ
> 
> With reverting it, everything works fine for me.
> 
> My board is arch/arm64/boot/dts/socionext/uniphier-ph1-ld20-ref.dts
> 
> Is anything wrong with IRQ settings in my Device Tree?

Most likely.

> If 1e2a7d784 is really a buggy commit,
> could you do something please?

Before this commit bad IRQ type settings in device-tree were not getting
reported and so that's why most likely it is bad IRQ type settings. As
Marc mentioned without any more details (which IRQ for which device is
failing) we cannot confirm. So I would look at the failing IRQ which is
now failing when being requested and see if the type in device-tree is
correct.

Cheers
Jon

-- 
nvpublic

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-07-29 06:00 +0200
  Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Marc Zyngier <marc.zyngier@arm.com> - 2016-07-29 10:20 +0200
    Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 03:40 +0200
      Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Marc Zyngier <marc.zyngier@arm.com> - 2016-08-01 09:50 +0200
        Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 10:40 +0200
  Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Jon Hunter <jonathanh@nvidia.com> - 2016-07-29 10:40 +0200
    Re: [PATCH V6 3/9] irqdomain: Don't set type when mapping an IRQ Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-01 05:20 +0200

csiph-web