Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1455495

Re: Please don't replace numeric parameter like 0444 with macro

Show all headers | View raw

On 08/02/2016 03:58 PM, Linus Torvalds wrote:
> [ So I answered similarly to another patch, but I'll just re-iterate
> and change the subject line so that it stands out a bit from the
> millions of actual patches ]
> 
> On Tue, Aug 2, 2016 at 1:42 PM, Pavel Machek <pavel@ucw.cz> wrote:
>>
>> Everyone knows what 0644 is, but noone can read S_IRUSR | S_IWUSR |
>> S_IRCRP | S_IROTH (*). Please don't do this.
> 
> Absolutely. It's *much* easier to parse and understand the octal
> numbers, while the symbolic macro names are just random line noise and
> hard as hell to understand. You really have to think about it.

Posix even specifies the numeric value for each macro in the chmod
command's extended description:

  http://pubs.opengroup.org/onlinepubs/9699919799/utilities/chmod.html

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Please don't replace numeric parameter like 0444 with macro Linus Torvalds <torvalds@linux-foundation.org> - 2016-08-02 23:00 +0200
  Re: Please don't replace numeric parameter like 0444 with macro Rob Landley <rob@landley.net> - 2016-08-03 00:00 +0200
  [PATCH] checkpatch: Look for symbolic permissions and suggest octal instead Joe Perches <joe@perches.com> - 2016-08-03 01:50 +0200
    Re: [PATCH] checkpatch: Look for symbolic permissions and suggest  octal instead Joe Perches <joe@perches.com> - 2016-08-03 02:40 +0200
    Re: [PATCH] checkpatch: Look for symbolic permissions and suggest  octal instead Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-03 04:10 +0200
  Re: Please don't replace numeric parameter like 0444 with macro Al Viro <viro@ZenIV.linux.org.uk> - 2016-08-03 02:50 +0200
    Re: Please don't replace numeric parameter like 0444 with macro Konstantin Khlebnikov <koct9i@gmail.com> - 2016-08-03 10:10 +0200
      Re: Please don't replace numeric parameter like 0444 with macro Richard Weinberger <richard.weinberger@gmail.com> - 2016-08-03 10:40 +0200
  [PATCH] Add file permission mode helpers Ingo Molnar <mingo@kernel.org> - 2016-08-03 10:20 +0200
    Re: [PATCH] Add file permission mode helpers Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-03 10:30 +0200
      Re: [PATCH] Add file permission mode helpers Ingo Molnar <mingo@kernel.org> - 2016-08-03 11:00 +0200
        Re: [PATCH] Add file permission mode helpers Willy Tarreau <w@1wt.eu> - 2016-08-03 11:30 +0200
      Re: [PATCH] Add file permission mode helpers Marcel Holtmann <marcel@holtmann.org> - 2016-08-03 12:00 +0200
    Re: [PATCH] Add file permission mode helpers Joe Perches <joe@perches.com> - 2016-08-03 17:50 +0200
    Re: [PATCH] Add file permission mode helpers Pavel Machek <pavel@ucw.cz> - 2016-08-03 19:00 +0200

csiph-web