Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454999

[PATCH 0487/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/media/pci/ivtv/ivtvfb.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c
index 8b95eef..5ca03ff 100644
--- a/drivers/media/pci/ivtv/ivtvfb.c
+++ b/drivers/media/pci/ivtv/ivtvfb.c
@@ -67,14 +67,14 @@ static int osd_left;
 static int osd_yres;
 static int osd_xres;
 
-module_param(ivtvfb_card_id, int, 0444);
-module_param_named(debug,ivtvfb_debug, int, 0644);
-module_param(osd_laced, bool, 0444);
-module_param(osd_depth, int, 0444);
-module_param(osd_upper, int, 0444);
-module_param(osd_left, int, 0444);
-module_param(osd_yres, int, 0444);
-module_param(osd_xres, int, 0444);
+module_param(ivtvfb_card_id, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param_named(debug,ivtvfb_debug, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
+module_param(osd_laced, bool, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(osd_depth, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(osd_upper, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(osd_left, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(osd_yres, int, S_IRUSR | S_IRGRP | S_IROTH);
+module_param(osd_xres, int, S_IRUSR | S_IRGRP | S_IROTH);
 
 MODULE_PARM_DESC(ivtvfb_card_id,
 		 "Only use framebuffer of the specified ivtv card (0-31)\n"
-- 
2.9.2

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 0487/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 18:50 +0200

csiph-web