Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454998

Re: [PATCH 0867/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

On Tue, 2016-08-02 at 19:53 +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access
> permission.
> As we know, these numeric value for access permission have had the
> corresponding macro,
> and that using macro can improve the robustness and readability of
> the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  
>  static int timeout = 5000;	/* in msec ( 5 sec ) */
> -module_param(timeout, int, 0644);
> +module_param(timeout, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);

To me, 644 is more 'readable', and as for robustness, the meaning of
644 will never change.

-Geoff

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0867/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:40 +0200
  Re: [PATCH 0867/1285] Replace numeric parameter like 0444 with macro Geoff Levand <geoff@infradead.org> - 2016-08-02 18:50 +0200

csiph-web