Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1454690
| From | James Bottomley <James.Bottomley@HansenPartnership.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro |
| Date | 2016-08-02 17:10 +0200 |
| Message-ID | <s1Juq-68b-31@gated-at.bofh.it> (permalink) |
| References | <s1GmS-3Sw-27@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2016-08-02 at 18:39 +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access > permission. As we know, these numeric value for access permission > have had the corresponding macro, and that using macro can improve > the robustness and readability of the code, thus, I suggest replacing > the numeric parameter with the macro. Please stop ... can't you see that sending out over a thousand emails with a single change in each is basically spam, especially for those of us who got our INBOXes filled by virtue of being on the direct cc. You don't need the thousand emails to achieve agreement over whether we should do this, and if we decide to do it, Linus would far rather run a simple script over the kernel as it is in an -rc state. Could you please begin a discussion by posting the suggestion and the script. Thanks, James
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 0082/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:50 +0200 Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro Laurence Oberman <loberman@redhat.com> - 2016-08-02 16:20 +0200 Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-08-02 17:10 +0200
csiph-web