[PATCH 0082/1285] Replace numeric parameter like 0444 with macro

From	Baole Ni <baolex.ni@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 0082/1285] Replace numeric parameter like 0444 with macro
Date	2016-08-02 13:50 +0200
Message-ID	<s1GmS-3Sw-27@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

I find that the developers often just specified the numeric value
when calling a macro which is defined with a parameter for access permission.
As we know, these numeric value for access permission have had the corresponding macro,
and that using macro can improve the robustness and readability of the code,
thus, I suggest replacing the numeric parameter with the macro.

Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
Signed-off-by: Baole Ni <baolex.ni@intel.com>
---
 drivers/block/cciss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index 63c2064..05dc1bd 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -67,7 +67,7 @@ MODULE_SUPPORTED_DEVICE("HP Smart Array Controllers");
 MODULE_VERSION("3.6.26");
 MODULE_LICENSE("GPL");
 static int cciss_tape_cmds = 6;
-module_param(cciss_tape_cmds, int, 0644);
+module_param(cciss_tape_cmds, int, S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH);
 MODULE_PARM_DESC(cciss_tape_cmds,
 	"number of commands to allocate for tape devices (default: 6)");
 static int cciss_simple_mode;
-- 
2.9.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 0082/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:50 +0200
  Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with  macro Laurence Oberman <loberman@redhat.com> - 2016-08-02 16:20 +0200
  Re: [PATCH 0082/1285] Replace numeric parameter like 0444 with macro James Bottomley <James.Bottomley@HansenPartnership.com> - 2016-08-02 17:10 +0200

csiph-web