Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1454611

Re: [PATCH 0987/1285] Replace numeric parameter like 0444 with macro

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Baole Ni <baolex.ni@intel.com> writes:

> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
>
> Signed-off-by: Chuansheng Liu <chuansheng.liu@intel.com>
> Signed-off-by: Baole Ni <baolex.ni@intel.com>
> ---
>  drivers/usb/phy/phy-twl6030-usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
> index a72e8d6..4ed75c6 100644
> --- a/drivers/usb/phy/phy-twl6030-usb.c
> +++ b/drivers/usb/phy/phy-twl6030-usb.c
> @@ -208,7 +208,7 @@ static ssize_t twl6030_usb_vbus_show(struct device *dev,
>  
>  	return ret;
>  }
> -static DEVICE_ATTR(vbus, 0444, twl6030_usb_vbus_show, NULL);
> +static DEVICE_ATTR(vbus, S_IRUSR | S_IRGRP | S_IROTH, twl6030_usb_vbus_show, NULL);

line too long

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0987/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 14:50 +0200
  Re: [PATCH 0987/1285] Replace numeric parameter like 0444 with macro Felipe Balbi <balbi@kernel.org> - 2016-08-02 16:50 +0200

csiph-web