Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1454590

Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro
Date 2016-08-02 16:40 +0200
Message-ID <s1J1p-5FG-49@gated-at.bofh.it> (permalink)
References <s1GmS-3Sw-57@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Aug 02, 2016 at 06:57:11PM +0800, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.

Please split these up and send them independently to the relevant
maintainers with sensible subject lines - a single 1000+ patch series is
far too large and you're CCing random people so it's hard to tell which
patches are relevant (for example the batch I'm replying to here are for
the input subsystem which I don't maintain so I'm not 100% sure why I'm
being copied here).

With this sort of thing it's often best to send one series per directory
or something similar.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0290/1285] Replace numeric parameter like 0444 with macro Baole Ni <baolex.ni@intel.com> - 2016-08-02 13:50 +0200
  Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro Mark Brown <broonie@kernel.org> - 2016-08-02 16:40 +0200
    Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro "Andrew F. Davis" <afd@ti.com> - 2016-08-02 17:00 +0200
  Re: [PATCH 0290/1285] Replace numeric parameter like 0444 with macro Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-02 19:40 +0200

csiph-web