Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy

From	Amit Tomer <amittomer25@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy
Date	2016-07-31 15:00 +0200
Message-ID	<s0Yvv-bq-1@gated-at.bofh.it> (permalink)
References	<s0Yvv-bq-3@gated-at.bofh.it> <s0Yvv-bq-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello ,

> @@ -264,6 +266,12 @@ static int sun4i_usb_phy_init(struct phy *_phy)
>                 val = readl(phy->pmu + REG_PMU_UNK_H3);
>                 writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
>         } else {
> +               /* A64 needs also this unknown bit */
> +               if (data->cfg->type == sun50i_a64_phy) {
> +                       val = readl(phy->pmu + REG_PMU_UNK_H3);
> +                       writel(val & ~2, phy->pmu + REG_PMU_UNK_H3);
> +               }
> +

This bit is also set for H3, shall we reuse it or we should enclose it
in else-if part ?

Thanks
Amit.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/3] phy: sun4i: add support for A64 usb phy Amit Tomer <amittomer25@gmail.com> - 2016-07-31 15:00 +0200

csiph-web