Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1452269
| From | Daniel Wagner <daniel.wagner@bmw-carit.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion |
| Date | 2016-07-29 08:20 +0200 |
| Message-ID | <s09jj-RB-7@gated-at.bofh.it> (permalink) |
| References | <rZOox-39Z-5@gated-at.bofh.it> <rZOoy-39Z-17@gated-at.bofh.it> <rZYnU-1zx-9@gated-at.bofh.it> <rZYQW-20O-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 07/28/2016 09:01 PM, Bjorn Andersson wrote: > On Thu 28 Jul 11:33 PDT 2016, Dmitry Torokhov wrote: > >> On Thu, Jul 28, 2016 at 09:55:11AM +0200, Daniel Wagner wrote: >>> From: Daniel Wagner <daniel.wagner@bmw-carit.de> >>> > [..] >> >> Do not quite like it... I'd rather asynchronous request give out a >> firmware status pointer that could be used later on. >> >> pcu->fw_st = request_firmware_async(IMS_PCU_FIRMWARE_NAME, >> pcu, >> ims_pcu_process_async_firmware); >> if (IS_ERR(pcu->fw_st)) >> return PTR_ERR(pcu->fw_st); >> >> .... >> >> fw_loading_wait(pcu->fw_st); >> > > In the remoteproc case (patch 6) this would clean up the code, rather > than replacing the completion API 1 to 1. I like it! IIRC most drivers do it the same way. So request_firmware_async() indeed would be good thing to have. Let me try that. Thanks for the excellent feedback. cheers, daniel
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC v0 0/8] Reuse firmware loader helpers Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
[RFC v0 8/8] iwl4965: use firmware_stat instead of completion Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
[RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 20:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-07-28 21:10 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-07-29 08:20 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-07-30 14:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-07-30 19:00 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-31 09:30 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-01 14:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-02 00:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-02 08:00 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-02 08:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-02 09:00 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-02 10:00 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-08-03 09:10 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-03 18:20 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-03 20:20 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-03 18:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-03 20:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-04 00:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-03 09:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-03 13:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-03 17:20 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-03 17:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Arend van Spriel <arend.vanspriel@broadcom.com> - 2016-08-03 23:00 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-03 18:10 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-03 19:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-03 22:40 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-01 22:20 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-01 19:30 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-08-01 22:20 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-08-01 23:50 +0200
Re: [RFC v0 7/8] Input: ims-pcu: use firmware_stat instead of completion Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-31 09:20 +0200
[RFC v0 2/8] selftests: firmware: do not clutter output Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
[RFC v0 6/8] remoteproc: use firmware_stat instead of completion Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
[RFC v0 3/8] firmware: Factor out firmware load helpers Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
Re: [RFC v0 3/8] firmware: Factor out firmware load helpers Dan Williams <dcbw@redhat.com> - 2016-07-28 17:10 +0200
Re: [RFC v0 3/8] firmware: Factor out firmware load helpers Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-07-29 08:10 +0200
Re: [RFC v0 3/8] firmware: Factor out firmware load helpers Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-07-28 20:00 +0200
Re: [RFC v0 3/8] firmware: Factor out firmware load helpers Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-07-29 08:10 +0200
[RFC v0 4/8] Input: goodix: use firmware_stat instead of completion Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
Re: [RFC v0 4/8] Input: goodix: use firmware_stat instead of completion Bastien Nocera <hadess@hadess.net> - 2016-07-28 13:30 +0200
Re: [RFC v0 4/8] Input: goodix: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-07-28 14:10 +0200
Re: [RFC v0 4/8] Input: goodix: use firmware_stat instead of completion Bastien Nocera <hadess@hadess.net> - 2016-07-28 14:30 +0200
Re: [RFC v0 4/8] Input: goodix: use firmware_stat instead of completion Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-07-28 15:20 +0200
[RFC v0 1/8] selftests: firmware: do not abort test too early Daniel Wagner <wagi@monom.org> - 2016-07-28 10:00 +0200
csiph-web