Path: csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod From: Nicolin Chen Newsgroups: linux.kernel Subject: Re: [alsa-devel] [PATCH] ASoC: rt5659: Add mclk controls Date: Thu, 28 Jul 2016 23:00:02 +0200 Message-ID: References: X-Original-To: Lars-Peter Clausen Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=897tpK5Owb0NAXJcc5yjJQp553pefzu9aNPF3aNekqA=; b=edjzA2GdHtLEFhQpjAlLbdynydX1i/ChbfYpVdHGyry9EmLACLlNokeIN8e00/kew1 stO+cSqfGWI836G4x+ZIyB8juXXzEZxOBWONLXMG0MKJwunaUAtaWrSEZH+UqoD/PWuA NZA6k+8dvctdxcvvsBWMQKKXm+NQfIHSCLxm4u7YvGzysqV+kR9AZC+cNS0tpQ25fpBQ O8/BRT09LjZipk7EiAmtDWqcvpTnogGVTiWnEkOv21w5I+z+bd7zun7U/I1xE939nrpM BpWt9+D5cA7D41xLsYoCnyUFRxbrlz3LAjHfaBzS3B8xHiQJd9N4KSA/qZXfYR1P0vTE JL/g== X-Google-Dkim-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=897tpK5Owb0NAXJcc5yjJQp553pefzu9aNPF3aNekqA=; b=XVXzg9hYXoyc69yiWrJ6KF/+GT/TlUyFpmJe7yRb/6zzMu9Sc0fgLkA5b0dIaOhXs6 TOIcWjY+puOiMWk5Y7I7nUExJZN53jc0E8amsgA003ps25cJbVeW+j7lYIc55uQUx5Pt Mec5bedQgdYArUBwXj/vWen6JJ68YBfp6noTDJI//xj3ydopHCfpmzt6U5MoUX2CtY0V ClZmsawrX2b3ieU0TJ5LyK45HSJtkLteuVkP49OQdJ7vmsjmbI6atI3vCR826Fa2/cB1 WTRR1neTJRb0NksH+d9sfTRJ1ZrXKvRa8wASApibOs6NThWkgf/5nPLsygfWGweBKNbV LVCg== X-Gm-Message-State: AEkoousfXNGcrdG0Qfy10KDE4/Bl8NR5W6KGkZmmlQwoV03WxS7dEMiAlzmm5h2NJ3h2GQ== X-Received: by 10.98.77.70 with SMTP id a67mr61433995pfb.151.1469739065107; Thu, 28 Jul 2016 13:51:05 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) Sender: robomod@news.nic.it List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Approved: robomod@news.nic.it Lines: 12 Organization: linux.* mail to news gateway X-Original-Cc: broonie@kernel.org, mark.rutland@arm.com, oder_chiou@realtek.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bardliao@realtek.com X-Original-Date: Thu, 28 Jul 2016 13:51:08 -0700 X-Original-Message-ID: <20160728205107.GA6804@Asurada-Nvidia> X-Original-References: <1469660568-3511-1-git-send-email-nicoleotsuka@gmail.com> <579A6DCC.6060401@metafoo.de> X-Original-Sender: linux-kernel-owner@vger.kernel.org Xref: csiph.com linux.kernel:1452099 On Thu, Jul 28, 2016 at 10:40:44PM +0200, Lars-Peter Clausen wrote: > > + /* Check if MCLK provided */ > > + rt5659->mclk = devm_clk_get(&i2c->dev, "mclk"); > > + if (IS_ERR(rt5659->mclk)) { > > + if (PTR_ERR(rt5659->mclk) == -EPROBE_DEFER) > > + return -EPROBE_DEFER; > > The correct thing to do here is to check if != -ENOENT and then return > the error code. Otherwise you silently ignore errors if a clock was > specified, but there was an error requesting it. Oh..Thanks for the input. Will refine it in v2.