Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1402477

Re: [PATCH v2] tpm: Factor out common startup code

Show all headers | View raw

On Tue, May 17, 2016 at 07:15:57AM +0300, Jarkko Sakkinen wrote:
> On Mon, May 16, 2016 at 12:25:47PM -0600, Jason Gunthorpe wrote:
> > Provide some flags in tpm_class_ops to allow drivers to opt-in to the
> > common startup sequence. This is the sequence used by tpm_tis and
> > tpm_crb.
> > 
> > All drivers should set this flag.
> 
> The commit message should be a much much more verbose I cannot include
> this without a better explanation. Please update this for the next
> revision.

What more description do you want to see?

> > +	if (chip->ops->flags & TPM_OPS_PROBE_TPM2) {
> > +		rc = tpm2_probe(chip);
> > +		if (rc)
> > +			return rc;
> > +	}
> 
> Dead code.

Yes, this is used by the follow on driver updates. Andrew is going to
be sending a patch that uses it right away. I don't really care if it
gets shifted to that patch or not..

Jason

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] tpm: Factor out common startup code Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-16 20:30 +0200
  Re: [PATCH v2] tpm: Factor out common startup code Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-05-17 06:20 +0200
    Re: [PATCH v2] tpm: Factor out common startup code Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-17 19:00 +0200
      Re: [PATCH v2] tpm: Factor out common startup code Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-05-18 12:00 +0200
        Re: [PATCH v2] tpm: Factor out common startup code Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-05-18 19:20 +0200
          Re: [PATCH v2] tpm: Factor out common startup code Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-05-19 11:10 +0200
  Re: [PATCH v2] tpm: Factor out common startup code Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-05-26 14:30 +0200

csiph-web