[PATCH 05/11] serial: pic32_uart: Fix double free of 'sport->irq_fault_name'.

From	Purna Chandra Mandal <purna.mandal@microchip.com>
Newsgroups	linux.kernel
Subject	[PATCH 05/11] serial: pic32_uart: Fix double free of 'sport->irq_fault_name'.
Date	2016-05-17 07:10 +0200
Message-ID	<rzFqy-fn-15@gated-at.bofh.it> (permalink)
References	<rzFqx-fn-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Allocated memory for 'sport->irq_fault_name' is freed twice, first
in error check of 'if(!sport->irq_rx_name)' and other in fallback
handler.

Signed-off-by: Purna Chandra Mandal <purna.mandal@microchip.com>

---

 drivers/tty/serial/pic32_uart.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/tty/serial/pic32_uart.c b/drivers/tty/serial/pic32_uart.c
index 62a43bf..7f8e99b 100644
--- a/drivers/tty/serial/pic32_uart.c
+++ b/drivers/tty/serial/pic32_uart.c
@@ -445,7 +445,6 @@ static int pic32_uart_startup(struct uart_port *port)
 				       sport->idx);
 	if (!sport->irq_rx_name) {
 		dev_err(port->dev, "%s: kasprintf err!", __func__);
-		kfree(sport->irq_fault_name);
 		ret = -ENOMEM;
 		goto out_f;
 	}
-- 
1.8.3.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 05/11] serial: pic32_uart: Fix double free of 'sport->irq_fault_name'. Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-05-17 07:10 +0200

csiph-web