Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi

Path	csiph.com!news.freedyn.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi
Date	Fri, 13 May 2016 15:20:02 +0200
Message-ID	<rylay-3Vi-25@gated-at.bofh.it> (permalink)
References	<rygkx-7Xv-3@gated-at.bofh.it> <rygkz-7Xv-29@gated-at.bofh.it>
X-Original-To	Yisen Zhuang <Yisen.Zhuang@huawei.com>, davem@davemloft.net, rjw@rjwysocki.net, lenb@kernel.org
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,614,1455004800"; d="scan'208";a="702251533"
Organization	Intel Finland Oy
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.18.5.1-1
MIME-Version	1.0
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
X-Original-Cc	arnd@arndb.de, andrew@lunn.ch, geliangtang@163.com, ivecera@redhat.com, fengguang.wu@intel.com, charles.chenxin@huawei.com, haifeng.wei@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com
X-Original-Date	Fri, 13 May 2016 16:12:16 +0300
X-Original-Message-ID	<1463145136.17131.344.camel@linux.intel.com>
X-Original-References	<1463127557-90824-1-git-send-email-Yisen.Zhuang@huawei.com> <1463127557-90824-8-git-send-email-Yisen.Zhuang@huawei.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1400792

Show key headers only | View raw

On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote:
> From: Kejian Yan <yankejian@huawei.com>
> 
> Dsaf needs to get configuration parameter by ACPI, so this patch add
> support of ACPI.
> 

Looks like at some point better to split driver to core part, and PCI
and ACPI/DT/platform code.

Too many changes where IS_ENABLED() involved shows as I can imagine bad
architecture / split of the driver.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Thread

[patch net-next 00/11] net: hns: add support of ACPI Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 09/11] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 08/11] net: hns: register phy device in each mac initial sequence Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 10/11] net: hns: implement the reset sequence by asl Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 07/11] net: hns: dsaf adds support of acpi Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
    Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-13 15:20 +0200
      Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-05-16 04:10 +0200
  [patch net-next 02/11] net: hns: use device_* APIs instead of of_* APIs Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 05/11] net: hns: add uniform interface for phy connection Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
    Re: [patch net-next 05/11] net: hns: add uniform interface for phy  connection Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-13 15:10 +0200
      Re: [patch net-next 05/11] net: hns: add uniform interface for phy  connection "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-05-16 04:10 +0200

csiph-web