Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1401153

Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi

Show all headers | View raw

On 2016/5/13 21:12, Andy Shevchenko wrote:
> On Fri, 2016-05-13 at 16:19 +0800, Yisen Zhuang wrote:
>> From: Kejian Yan <yankejian@huawei.com>
>>
>> Dsaf needs to get configuration parameter by ACPI, so this patch add
>> support of ACPI.
>>
> Looks like at some point better to split driver to core part, and PCI
> and ACPI/DT/platform code.
>
> Too many changes where IS_ENABLED() involved shows as I can imagine bad
> architecture / split of the driver.

Hi Andy,
Actully, we use the unified function asap. The routine in DT/ACPI maybe difference. Some routine
will be treated in BIOS in ACPI case, but it will be treated in OS in DT case, so we need to distinguish
it.
And we will try to reduce the use of IS_ENABLED().

Thanks very much for your suggestions, Andy

Kejian

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch net-next 00/11] net: hns: add support of ACPI Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 09/11] ACPI: bus: add stub acpi_evaluate_dsm() to linux/acpi.h Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 08/11] net: hns: register phy device in each mac initial sequence Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 10/11] net: hns: implement the reset sequence by asl Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 07/11] net: hns: dsaf adds support of acpi Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
    Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-13 15:20 +0200
      Re: [patch net-next 07/11] net: hns: dsaf adds support of acpi "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-05-16 04:10 +0200
  [patch net-next 02/11] net: hns: use device_* APIs instead of of_* APIs Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
  [patch net-next 05/11] net: hns: add uniform interface for phy connection Yisen Zhuang <Yisen.Zhuang@huawei.com> - 2016-05-13 10:10 +0200
    Re: [patch net-next 05/11] net: hns: add uniform interface for phy  connection Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-05-13 15:10 +0200
      Re: [patch net-next 05/11] net: hns: add uniform interface for phy  connection "Yankejian (Hackim Yim)" <yankejian@huawei.com> - 2016-05-16 04:10 +0200

csiph-web