Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400326

Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3

Show all headers | View raw

On Thu, May 12, 2016 at 09:51:22PM +0200, Benjamin Tissoires wrote:
> On May 12 2016 or thereabouts, Dmitry Torokhov wrote:
> > On Thu, May 12, 2016 at 05:07:54PM +0200, Benjamin Tissoires wrote:
> > > +static int __maybe_unused ntrig_spi_suspend(struct device *dev)
> > > +{
> > > +	struct spi_device *spi = to_spi_device(dev);
> > > +	struct ntrig *data = spi_get_drvdata(spi);
> > > +
> > > +	ntrig_spi_free_irq(data);
> > 
> > Why?
> 
> To disable the IRQ and be sure we won't wake up the device...
> It might just work without though.

Or you can do disable_irq(). Do you want it to be wakeup source by
chance? Then you need to wire it up some more.

Thanks.

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Input - ntrig_spi: add new driver for the Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-05-12 17:10 +0200
  Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-12 21:20 +0200
    Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-05-12 22:00 +0200
      Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3 Bastien Nocera <hadess@hadess.net> - 2016-05-12 22:00 +0200
      Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3 Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-05-12 22:00 +0200
      Re: [PATCH] Input - ntrig_spi: add new driver for the Surface 3 Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2016-05-13 17:10 +0200

csiph-web