Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400266

Re: [PATCH] mfd: max77620: Fix FPS switch statements

Show all headers | View raw

On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
> When configuring FPS during probe, assuming a DT node is present for
> FPS, the code can run into a problem with the switch statements in
> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
> in the case of chip->chip_id == MAX77620, it will set
> fps_[mix|max]_period but then fall through to the default switch case
> and return -EINVAL. Returning this from max77620_config_fps() will
> cause probe to fail.
>

Thanks for fixes.
Missed when converting if-else to switch.

Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein <rklein@nvidia.com> - 2016-05-12 19:50 +0200
  Re: [PATCH] mfd: max77620: Fix FPS switch statements Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-12 20:10 +0200
    Re: [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein <rklein@nvidia.com> - 2016-05-27 22:40 +0200
      Re: [PATCH] mfd: max77620: Fix FPS switch statements Lee Jones <lee.jones@linaro.org> - 2016-05-31 09:40 +0200

csiph-web