Re: [PATCH] mfd: max77620: Fix FPS switch statements

From	Lee Jones <lee.jones@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mfd: max77620: Fix FPS switch statements
Date	2016-05-31 09:40 +0200
Message-ID	<rEMrn-83O-19@gated-at.bofh.it> (permalink)
References	<ry2Uh-24P-1@gated-at.bofh.it> <ry3dE-2EM-7@gated-at.bofh.it> <rDwI2-861-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 27 May 2016, Rhyland Klein wrote:

> On 5/12/2016 1:52 PM, Laxman Dewangan wrote:
> > 
> > On Thursday 12 May 2016 11:15 PM, Rhyland Klein wrote:
> >> When configuring FPS during probe, assuming a DT node is present for
> >> FPS, the code can run into a problem with the switch statements in
> >> max77620_config_fps() and max77620_get_fps_period_reg_value(). Namely,
> >> in the case of chip->chip_id == MAX77620, it will set
> >> fps_[mix|max]_period but then fall through to the default switch case
> >> and return -EINVAL. Returning this from max77620_config_fps() will
> >> cause probe to fail.
> >>
> > 
> > Thanks for fixes.
> > Missed when converting if-else to switch.
> > 
> > Reviewed-by: Laxman Dewangan <ldewangan@nvidia.com>
> > 
> 
> Lee, I noticed this hasn't been merged yet, but without it platforms
> using the max77620 can easily (if it has FPS nodes) fail to probe. Is
> there anything blocking it?

Yes, it was sent too late in the cycle.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Thread

[PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein <rklein@nvidia.com> - 2016-05-12 19:50 +0200
  Re: [PATCH] mfd: max77620: Fix FPS switch statements Laxman Dewangan <ldewangan@nvidia.com> - 2016-05-12 20:10 +0200
    Re: [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein <rklein@nvidia.com> - 2016-05-27 22:40 +0200
      Re: [PATCH] mfd: max77620: Fix FPS switch statements Lee Jones <lee.jones@linaro.org> - 2016-05-31 09:40 +0200
        Re: [PATCH] mfd: max77620: Fix FPS switch statements Rhyland Klein <rklein@nvidia.com> - 2016-06-01 17:30 +0200
        Re: [PATCH] mfd: max77620: Fix FPS switch statements Thierry Reding <thierry.reding@gmail.com> - 2016-06-06 17:40 +0200
  Re: [PATCH] mfd: max77620: Fix FPS switch statements Lee Jones <lee.jones@linaro.org> - 2016-06-07 10:10 +0200

csiph-web