Re: [PATCH v3 2/2] drm: Add helper for simple display pipeline

From	Daniel Vetter <daniel@ffwll.ch>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 2/2] drm: Add helper for simple display pipeline
Date	2016-05-12 17:40 +0200
Message-ID	<ry0Su-l8-29@gated-at.bofh.it> (permalink)
References	<rxYnE-61H-3@gated-at.bofh.it> <rxYnE-61H-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, May 12, 2016 at 02:53:26PM +0200, Noralf Trønnes wrote:
> +/**
> + * struct drm_simple_display_pipe - simple display pipeline
> + * @crtc: CRTC control structure
> + * @plane: Plane control structure
> + * @encoder: Encoder control structure
> + * @connector: Connector control structure
> + * @funcs: Pipeline control functions (optional)
> + *
> + * Simple display pipeline with plane, crtc and encoder collapsed into one
> + * entity. It should be initialized by calling drm_simple_display_pipe_init().
> + */
> +struct drm_simple_display_pipe {
> +	struct drm_crtc crtc;
> +	struct drm_plane plane;
> +	struct drm_encoder encoder;
> +	struct drm_connector *connector;
> +
> +	struct drm_simple_display_pipe_funcs *funcs;
> +};

Same thing as in the previous patch: Function table pointers should be
const. I totally forgot about this.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/2] drm: Add various helpers for simple drivers Noralf Trønnes <noralf@tronnes.org> - 2016-05-12 15:00 +0200
  [PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() Noralf Trønnes <noralf@tronnes.org> - 2016-05-12 15:00 +0200
    Re: [PATCH v3 1/2] drm/fb-cma-helper: Add function drm_fb_cma_create_with_funcs() Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2016-05-12 15:50 +0200
      Re: [PATCH v3 1/2] drm/fb-cma-helper: Add function  drm_fb_cma_create_with_funcs() Noralf Trønnes <noralf@tronnes.org> - 2016-05-12 16:50 +0200
  [PATCH v3 2/2] drm: Add helper for simple display pipeline Noralf Trønnes <noralf@tronnes.org> - 2016-05-12 15:00 +0200
    Re: [PATCH v3 2/2] drm: Add helper for simple display pipeline Daniel Vetter <daniel@ffwll.ch> - 2016-05-12 17:40 +0200

csiph-web