Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1400164

[PATCH 3/3] tty/serial: atmel: add comment for the ring buffer size macro

Show all headers | View raw

There is a macro named ATMEL_SERIAL_RINGSIZE which suggesting that it
corresponds to the real size of the ring buffer. Let warn people that
there is a factor of four since allocation size is
sizeof(struct atmel_uart_char) * ATMEL_SERIAL_RINGSIZE.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/tty/serial/atmel_serial.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 6c1ec7d..8570163 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -108,6 +108,12 @@ struct atmel_uart_char {
 	u16		ch;
 };
 
+/*
+ * Be careful, the real size of the ring buffer is
+ * sizeof(atmel_uart_char) * ATMEL_SERIAL_RINGSIZE. It means that ring buffer
+ * can contain up to 1024 characters in PIO mode and up to 4096 characters in
+ * DMA mode.
+ */
 #define ATMEL_SERIAL_RINGSIZE 1024
 
 /*
-- 
2.5.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] tty/serial: atmel: re-integrate status check in irq handler Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-05-12 17:40 +0200
  [PATCH 3/3] tty/serial: atmel: add comment for the ring buffer size macro Ludovic Desroches <ludovic.desroches@atmel.com> - 2016-05-12 17:40 +0200
    Re: [PATCH 3/3] tty/serial: atmel: add comment for the ring buffer  size macro Nicolas Ferre <nicolas.ferre@atmel.com> - 2016-05-12 18:00 +0200

csiph-web