Re: [PATCH BUGFIX V4] block: add missing group association in bio-cloning functions

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH BUGFIX V4] block: add missing group association in bio-cloning functions
Date	Thu, 12 May 2016 17:30:01 +0200
Message-ID	<ry0IN-eN-3@gated-at.bofh.it> (permalink)
References	<rxw81-2LF-3@gated-at.bofh.it> <rxyCT-5ns-25@gated-at.bofh.it>
X-Original-To	Paolo Valente <paolo.valente@linaro.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0Db1X8q5VieEvBzT5QjjCvK9qagou5m+FDMibnwK7HA=; b=crV3JQ22p+jnKzbRx/zIh5jjQb+W2/DTIdaW0zWw4b7VzWNvkGsOItAWt0v3jKC+Yk IS/K2li8zHHHGHXMNz6D5ArFCDMYRXhlutxoPngaO3gKlo2DUKidz8fP/ylpCZciGiQu w+ynjn0eP3WIXF8trAtF1hgZ1UkOIOBaeCFzjrDN02l19Z124jv1g/7Fo1lrKWJ9CSAU nzvVSDGGmFrqHekJAubT0lMOt4n+SWtE17E/GWONojTPTwSjgT6YwK++h3RSgvpNjU00 Oz8i8nZxSvzCfX+LNKBe0cK0kZmjjzqbkM4cGvYNq4NVwBvQBxhs7S5Qw3Vhr5e/AOB7 jeZA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=0Db1X8q5VieEvBzT5QjjCvK9qagou5m+FDMibnwK7HA=; b=acMuZPqqc556+zm9LHKW4ImnjPVxSCM47dB8g0jMmM2zR60lm/tu9hfdr9cp9LB6/e usIl2Y1JnluTjjK0z5Mxzd5ktPtlSt57Cvs/6a2tpjxGWx6RIS9fkOrG1wkzfQBrwXJO 81IG9URKvvFqzPaeuJAM6WJJk1GTlx4CoOuaz23ZB3MHG1jzApUdXlBmKp3SKMopuTkc eer1AAq25I2UetL0jmFeErjoE/pr/HYxh47h0Tse1orlxmuYEuR1J/KOqP9lPW99WfdW VtYPQHG/x38xA8g1jzxIIky/xqm1NG5GetYJbn5TmZHOJiYH8JDs6fHukyEkW+L3talj 3RsQ==
X-Gm-Message-State	AOPr4FWN+N1N+L4301rLRvy4oGNqhDkc5vuHNlEf61ORhtu2fWXWkYChaCNRK4GwoBsHAA==
X-Received	by 10.37.196.71 with SMTP id u68mr1584882ybf.52.1463065846657; Thu, 12 May 2016 08:10:46 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, linus.walleij@linaro.org, broonie@kernel.org, stable@vger.kernel.org
X-Original-Date	Thu, 12 May 2016 11:10:45 -0400
X-Original-Message-ID	<20160512151045.GR4775@htj.duckdns.org>
X-Original-References	<5732D47A.4090706@kyup.com> <1462958884-9457-1-git-send-email-paolo.valente@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1400148

Show key headers only | View raw

On Wed, May 11, 2016 at 11:28:04AM +0200, Paolo Valente wrote:
> When a bio is cloned, the newly created bio must be associated with
> the same blkcg as the original bio (if BLK_CGROUP is enabled). If
> this operation is not performed, then the new bio is not associated
> with any group, and the group of the current task is returned when
> the group of the bio is requested.
> 
> Depending on the cloning frequency, this may cause a large
> percentage of the bios belonging to a given group to be treated
> as if belonging to other groups (in most cases as if belonging to
> the root group). The expected group isolation may thereby be broken.
> 
> This commit adds the missing association in bio-cloning functions.
> 
> Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
> Reviewed-by: Nikolay Borisov <kernel@kyup.com>

 Acked-by: Tejun Heo <tj@kernel.org>

It prolly should also have the following tags

Fixes: da2f0f74cf7d ("Btrfs: add support for blkio controllers")
Cc: stable@vger.kernel.org # v4.3+

Thanks.

-- 
tejun

Thread

[PATCH BUGFIX] block: add missing group association in bio_split Paolo Valente <paolo.valente@linaro.org> - 2016-05-06 23:30 +0200
  Re: [PATCH BUGFIX] block: add missing group association in bio_split Jeff Moyer <jmoyer@redhat.com> - 2016-05-09 16:20 +0200
    Re: [PATCH BUGFIX] block: add missing group association in bio_split Jeff Moyer <jmoyer@redhat.com> - 2016-05-09 16:40 +0200
      Re: [PATCH BUGFIX] block: add missing group association in bio_split Paolo <paolo.valente@linaro.org> - 2016-05-09 16:40 +0200
        Re: [PATCH BUGFIX] block: add missing group association in bio_split Mark Brown <broonie@kernel.org> - 2016-05-09 17:00 +0200
          Re: [PATCH BUGFIX] block: add missing group association in bio_split Jens Axboe <axboe@kernel.dk> - 2016-05-09 20:00 +0200
            [PATCH BUGFIX] block: add missing group association in bio_split Paolo Valente <paolo.valente@linaro.org> - 2016-05-10 11:10 +0200
              Re: [PATCH BUGFIX] block: add missing group association in bio_split Jeff Moyer <jmoyer@redhat.com> - 2016-05-10 18:20 +0200
                Re: [PATCH BUGFIX] block: add missing group association in bio_split Paolo <paolo.valente@linaro.org> - 2016-05-10 19:10 +0200
                [PATCH BUGFIX] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-10 22:30 +0200
                Re: [PATCH BUGFIX] block: add missing group association in  bio-cloning functions Tejun Heo <tj@kernel.org> - 2016-05-10 22:50 +0200
                Re: [PATCH BUGFIX V2] block: add missing group association in  bio-cloning functions Tejun Heo <tj@kernel.org> - 2016-05-10 23:10 +0200
                [PATCH BUGFIX V2] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-10 23:10 +0200
                Re: [PATCH BUGFIX V2] block: add missing group association in bio-cloning functions Jeff Moyer <jmoyer@redhat.com> - 2016-05-10 23:40 +0200
                Re: [PATCH BUGFIX V2] block: add missing group association in  bio-cloning functions Paolo <paolo.valente@linaro.org> - 2016-05-10 23:50 +0200
                [PATCH BUGFIX V3] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-11 00:10 +0200
                Re: [PATCH BUGFIX V3] block: add missing group association in  bio-cloning functions Nikolay Borisov <kernel@kyup.com> - 2016-05-11 08:40 +0200
                Re: [PATCH BUGFIX V3] block: add missing group association in  bio-cloning functions Nikolay Borisov <kernel@kyup.com> - 2016-05-11 08:50 +0200
                Re: [PATCH BUGFIX V3] block: add missing group association in  bio-cloning functions Paolo <paolo.valente@linaro.org> - 2016-05-11 11:10 +0200
                [PATCH BUGFIX V4] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-11 11:30 +0200
                Re: [PATCH BUGFIX V4] block: add missing group association in  bio-cloning functions Tejun Heo <tj@kernel.org> - 2016-05-12 17:30 +0200
                Re: [PATCH BUGFIX V4] block: add missing group association in bio-cloning functions Jeff Moyer <jmoyer@redhat.com> - 2016-05-13 22:50 +0200
        Re: [PATCH BUGFIX] block: add missing group association in bio_split Jens Axboe <axboe@kernel.dk> - 2016-05-09 17:00 +0200
  Re: [PATCH BUGFIX] block: add missing group association in bio_split Tejun Heo <tj@kernel.org> - 2016-05-09 17:30 +0200

csiph-web