Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1397101

Re: [PATCH BUGFIX] block: add missing group association in bio_split

From Paolo <paolo.valente@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH BUGFIX] block: add missing group association in bio_split
Date 2016-05-09 16:40 +0200
Message-ID <rwUvM-7tx-23@gated-at.bofh.it> (permalink)
References <rvVtU-4cT-5@gated-at.bofh.it> <rwUcp-7gU-5@gated-at.bofh.it> <rwUvL-7tx-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Il 09/05/2016 16:35, Jeff Moyer ha scritto:
> Jeff Moyer <jmoyer@redhat.com> writes:
>
>> Paolo Valente <paolo.valente@linaro.org> writes:
>>
>>> @@ -1811,6 +1811,11 @@ struct bio *bio_split(struct bio *bio, int sectors,
>>>
>>>   	bio_advance(bio, split->bi_iter.bi_size);
>>>
>>> +#ifdef CONFIG_BLK_CGROUP
>>> +	if (bio->bi_css)
>>> +		bio_associate_blkcg(split, bio->bi_css);
>>> +#endif
>>> +
>>>   	return split;
>>>   }
>>>   EXPORT_SYMBOL(bio_split);
>>
>> Get rid of the #ifdefery.  This should be just:
>>
>> bio_associate_blkcg(split, bio->bi_css);
>
> Gah, I see that the bi_css member is only present for CONFIG_BLK_CGROUP.
> I guess we'll have to live with the ifdef.
>

We have already tried to remove it, but it seems it would require other 
major changes.

Thanks,
Paolo

> -Jeff
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH BUGFIX] block: add missing group association in bio_split Paolo Valente <paolo.valente@linaro.org> - 2016-05-06 23:30 +0200
  Re: [PATCH BUGFIX] block: add missing group association in bio_split Jeff Moyer <jmoyer@redhat.com> - 2016-05-09 16:20 +0200
    Re: [PATCH BUGFIX] block: add missing group association in bio_split Jeff Moyer <jmoyer@redhat.com> - 2016-05-09 16:40 +0200
      Re: [PATCH BUGFIX] block: add missing group association in bio_split Paolo <paolo.valente@linaro.org> - 2016-05-09 16:40 +0200
        Re: [PATCH BUGFIX] block: add missing group association in bio_split Mark Brown <broonie@kernel.org> - 2016-05-09 17:00 +0200
          Re: [PATCH BUGFIX] block: add missing group association in bio_split Jens Axboe <axboe@kernel.dk> - 2016-05-09 20:00 +0200
            [PATCH BUGFIX] block: add missing group association in bio_split Paolo Valente <paolo.valente@linaro.org> - 2016-05-10 11:10 +0200
              Re: [PATCH BUGFIX] block: add missing group association in bio_split Jeff Moyer <jmoyer@redhat.com> - 2016-05-10 18:20 +0200
                Re: [PATCH BUGFIX] block: add missing group association in bio_split Paolo <paolo.valente@linaro.org> - 2016-05-10 19:10 +0200
                [PATCH BUGFIX] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-10 22:30 +0200
                Re: [PATCH BUGFIX] block: add missing group association in  bio-cloning functions Tejun Heo <tj@kernel.org> - 2016-05-10 22:50 +0200
                Re: [PATCH BUGFIX V2] block: add missing group association in  bio-cloning functions Tejun Heo <tj@kernel.org> - 2016-05-10 23:10 +0200
                [PATCH BUGFIX V2] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-10 23:10 +0200
                Re: [PATCH BUGFIX V2] block: add missing group association in bio-cloning functions Jeff Moyer <jmoyer@redhat.com> - 2016-05-10 23:40 +0200
                Re: [PATCH BUGFIX V2] block: add missing group association in  bio-cloning functions Paolo <paolo.valente@linaro.org> - 2016-05-10 23:50 +0200
                [PATCH BUGFIX V3] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-11 00:10 +0200
                Re: [PATCH BUGFIX V3] block: add missing group association in  bio-cloning functions Nikolay Borisov <kernel@kyup.com> - 2016-05-11 08:40 +0200
                Re: [PATCH BUGFIX V3] block: add missing group association in  bio-cloning functions Nikolay Borisov <kernel@kyup.com> - 2016-05-11 08:50 +0200
                Re: [PATCH BUGFIX V3] block: add missing group association in  bio-cloning functions Paolo <paolo.valente@linaro.org> - 2016-05-11 11:10 +0200
                [PATCH BUGFIX V4] block: add missing group association in bio-cloning functions Paolo Valente <paolo.valente@linaro.org> - 2016-05-11 11:30 +0200
        Re: [PATCH BUGFIX] block: add missing group association in bio_split Jens Axboe <axboe@kernel.dk> - 2016-05-09 17:00 +0200
  Re: [PATCH BUGFIX] block: add missing group association in bio_split Tejun Heo <tj@kernel.org> - 2016-05-09 17:30 +0200

csiph-web